Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding generics to avoid casting the getRawLogs() #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahus1
Copy link

@ahus1 ahus1 commented Sep 30, 2018

I've seen your comment "Avoid the ugly cast in getRawLogs" in the readme. This is a try to avoid this cast using generics.

Let me know what you think. If you think is not useful or the wrong direction, feel free to close the PR.

@haasted
Copy link
Owner

haasted commented Oct 4, 2018

Thank you very much for your contribution! I'm very excited to receive a PR for this issue.

I hope to find time to look at it in the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants