Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openresty] Update openresty to 1.15.8.1, add tests #2726

Merged
merged 1 commit into from
Jul 2, 2019
Merged

[openresty] Update openresty to 1.15.8.1, add tests #2726

merged 1 commit into from
Jul 2, 2019

Conversation

predominant
Copy link
Collaborator

Signed-off-by: Graham Weldon graham@grahamweldon.com

Testing

hab pkg build openresty
source results/last_build.env
hab studio run "./openresty/tests/test.sh ${pkg_ident}"

Sample output

 ✓ Version matches
 ✓ Service is running
 ✓ Listening on port 80

3 tests, 0 failures

@predominant predominant requested a review from a team as a code owner June 26, 2019 00:09
@chef-expeditor
Copy link
Contributor

Hello predominant! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

echohack
echohack suggested changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@echohack echohack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, builds great, tests great! Just one small question before we can merge.

openresty/tests/test.bats Outdated Show resolved Hide resolved
@predominant
Update openresty to 1.15.8.1, add tests
3454437 
Signed-off-by: Graham Weldon <graham@grahamweldon.com>
@predominant predominant force-pushed the predominant/openresty-1.15.8.1 branch from 7b73429 to 3454437 Compare June 27, 2019 01:19
echohack
echohack approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@echohack echohack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
pow0cegybst21

@echohack echohack merged commit dec69a6 into habitat-sh:master Jul 2, 2019
@echohack
Copy link
Contributor

echohack commented Jul 2, 2019

Built and promoted!

@predominant predominant deleted the predominant/openresty-1.15.8.1 branch July 3, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echohack echohack echohack approved these changes

Assignees
No one assigned
Labels
Focus:Core Plans Focus:Core-Plans Platform:Linux Type: minor-version-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@predominant @echohack