Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #63 Create Practice Area Model #156

Merged
merged 17 commits into from
May 31, 2023

Conversation

ethanstrominger
Copy link
Member

@ethanstrominger ethanstrominger commented May 3, 2023

Fixes Issue #63 Create Practice Area Model

@ethanstrominger ethanstrominger requested a review from fyliu May 3, 2023 20:37
Copy link
Member

@fyliu fyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Admin site and API endpoint works.
I think you're going to push the lint fixes.
Looks like there's a name mix up with the tests.

app/core/models.py Show resolved Hide resolved
app/core/tests/test_api.py Outdated Show resolved Hide resolved
app/core/tests/test_api.py Outdated Show resolved Hide resolved
app/core/tests/test_models.py Outdated Show resolved Hide resolved
Copy link
Member

@fyliu fyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more things.

app/core/admin.py Outdated Show resolved Hide resolved
app/core/api/views.py Show resolved Hide resolved
Copy link
Member

@fyliu fyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fyliu fyliu merged commit faa10be into hackforla:main May 31, 2023
@ExperimentsInHonesty
Copy link
Member

Fixes #63

AzaniaBG pushed a commit to AzaniaBG/peopledepot that referenced this pull request Apr 19, 2024
fix: add filenames for the code snippets

docs: fix CONTRIBUTING-related issues

Fix: create card for new issue automation

A recent project board name change broke the automation. This commit updates it to the new project name.

Issue hackforla#63 Create Practice Area Model (hackforla#156)

* Issue 63 Create Practice Area Model

issue 43: Create Program Area model (hackforla#161)

* feat: add model: program_area | feat: register admin: program_area | feat: add endpoints: program_area

Update README.md (hackforla#171)

added skill model

fixed bug in serializer.py

Feature technology table (hackforla#175)

* feat: add model: technology

* feat: register admin: technology

* feat: add endpoints: technology

* Lint warnings and code clean up. Removed unnecessary migration files. Corrected admin name.

* "Lint and code cleanup. Removing previous technology migration. Admin.py name update."

* Modified migrations for technology table.

Removed requirements for python version in pre-commit

fix: lint script not fixing code formatting

swapped black and flake8 in lint.sh file

feat: add language model and api endpoints

feature branch rebase with squashed commits for language model

Update issue templates

Add Permission-type tables
Squash all previous minor commits

Update existing Django model by deleting URL fileds

removed language table models and tests

Updated CONTRIBUTING.md file

Create pull_request_template.md

Add pr template from website team to this repo

Rename recurring_event to event

Set up django-linear-migrations

script: update superuser script to take no input

script: update scripts to take extra commandline args

config: show missing lines in coverage report

tests: add test for ProgramArea model

tests: program_area list

docs: move convenience scripts descriptions to a file

docs: update scripts descriptions for script fixes

squashed 28 commits

rebase origin main to update local main branch
@ethanstrominger ethanstrominger deleted the issue_63_create_practice_area branch July 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants