-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature technology table #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works well! The rest are code cleanup changes that don't affect functionality.
I'm listing them here.
-
There's a few lint warning that are supposed to be automatic fixes. They're whitespaces and import reorderings. You can install pre-commit to try to do that or I can just commit them. There's a pre-commit section in the contributing page. These commands are useful to know:
# run lint, which is a smaller set of checks than the pre-commit hooks, but doesn't require installing pre-commit ./scripts/lint.sh # the commands below require installing pre-commit # run individual pre-commit hooks pre-commit run end-of-file-fixer -a pre-commit run trailing-whitespace -a # run all the precommit hooks ./scripts/precommit-check.sh
-
The migration files can be combined into one since the first 2 cancel out. You can do that with these steps:
- Roll back to before the first new migration
docker-compose exec web python manage.py migrate core 0012
- Delete all the new migration files
rm app/core/migrations/{0013*,0014*,0015*}
- Rerun make migrations and migrate
docker-compose exec web python manage.py makemigrations docker-compose exec web python manage.py migrate
- Roll back to before the first new migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you made the requested changes. Great work.
fix: add filenames for the code snippets docs: fix CONTRIBUTING-related issues Fix: create card for new issue automation A recent project board name change broke the automation. This commit updates it to the new project name. Issue hackforla#63 Create Practice Area Model (hackforla#156) * Issue 63 Create Practice Area Model issue 43: Create Program Area model (hackforla#161) * feat: add model: program_area | feat: register admin: program_area | feat: add endpoints: program_area Update README.md (hackforla#171) added skill model fixed bug in serializer.py Feature technology table (hackforla#175) * feat: add model: technology * feat: register admin: technology * feat: add endpoints: technology * Lint warnings and code clean up. Removed unnecessary migration files. Corrected admin name. * "Lint and code cleanup. Removing previous technology migration. Admin.py name update." * Modified migrations for technology table. Removed requirements for python version in pre-commit fix: lint script not fixing code formatting swapped black and flake8 in lint.sh file feat: add language model and api endpoints feature branch rebase with squashed commits for language model Update issue templates Add Permission-type tables Squash all previous minor commits Update existing Django model by deleting URL fileds removed language table models and tests Updated CONTRIBUTING.md file Create pull_request_template.md Add pr template from website team to this repo Rename recurring_event to event Set up django-linear-migrations script: update superuser script to take no input script: update scripts to take extra commandline args config: show missing lines in coverage report tests: add test for ProgramArea model tests: program_area list docs: move convenience scripts descriptions to a file docs: update scripts descriptions for script fixes squashed 28 commits rebase origin main to update local main branch
Overview
Fixes #39
Action Items
add issue link to the tables tab of the spreadsheet
identify and document table description (see spreadsheet under Resources)
compare and check off the data fields (below) against the ERD. Note any fields in the ERD that's missing from the list. (see Resources)
compare the check off associated tables (below) against the ERD. Note any associated tables in the ERD that's missing from the list (see Resources)
create a single model in Django (defining schema)
write a test for the relationships this model will have with other models (e.g., creating a user and assigning them a set of permissions on a project).
write an API end point
write API unit tests
document the endpoint
Release Create Table: project_technology_xref #40 from ice box