Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Counting Activities in a PR as Activity Credit in Its Linked Issue #4536

Open
2 of 11 tasks
JessicaLucindaCheng opened this issue Apr 17, 2023 · 13 comments
Open
2 of 11 tasks
Assignees
Labels
Complexity: Large Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly GHA New Project Board compatible This GitHub Action issue does not reference columns and will work with the new board Issue Making: Level 4 Create an Epic Issue, and it's Level 2 or 3 issues ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Apr 17, 2023

Note: This issue came from the Task List Dev Leads.

Emergent Requirement - Problem

Currently, issues with a linked open pull request (PR) will not get an automated comment requesting the assignee of the issue for an update nor a To Update ! label if it has been a week. The same thing happens for the 2 weeks inactive comment and label, where the comment and label are not added if there is an open linked PR to the issue.

Problem: If the PR's author (aka assignee of the associated issue) of an open PR doesn't make requested changes promptly and there is no 2 weeks inactive label on the PR's associated issue, this may cause the following problems:

  • The PR may get old and stale.
  • There may be no updates/ETA from the developer on when the changes will be made, so we won't know if and when changes will be made.
  • With no updates, we may not be able to tell if the developer ghosted us or is inactive for some reason.
  • Also, this may cause issues to sit in the "In progress (actively working)" column indefinitely, since they may not be checked by leads, Merge Team members, or PMs if they don't have a 2 weeks inactive label.

Who was involved

What happens if this is not addressed

  • All issues with a linked open PR have to be manually checked to see their status/activity and if they have gone stale, which can take up a lot of time.

Resources

Recommended Action Items

  • Discuss with the team first if this still needs to be addressed or if the problem is no longer an issue because other processes in place address the problem. Ans: This is still a problem that should be addressed.
  • If it is still a problem, decide upon what the solution will be.
  • Write an epic

Potential Solutions [Draft]

  • Write an epic containing the following:

Counting Activities in a PR as Activity Credit in Its Linked Issue

Each of the following issues will count the described activity in the PR as activity credit in its linked issue.

  • A Complexity: Large issue to implement counting the activity of creating a PR by the issue's assignee (a.k.a. the PR's author). This currently is automatically noted on the issue.
  • A Complexity: Large issue to implement counting the activity when reviewers are assigned to a PR.
  • A Complexity: Large issue to implement counting the activity when a PR's author makes a new commit in the PR.
  • A Complexity: Large issue to implement counting the activity when a PR's author makes a new comment in the PR.
  • A Complexity: Large issue to implement counting the activity when a PR is merged.

Turn on To Update ! and 2 weeks inactive Automations

  • A Complexity: Large issue to implement turning on the automation for To Update ! and 2 weeks inactive labels for issues with a linked open PR and the issues are in the "In progress (actively working)" column.
    • This issue will have a "Dependency" section with a link to each of the issues written for the "Counting Activities in a PR as Activity Credit in Its Linked Issue" section
@JessicaLucindaCheng JessicaLucindaCheng added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 1pt Can be done in 4-6 hours Issue Making: Level 2 Make issue(s) from an ER or Epic ready for dev lead Issues that tech leads or merge team members need to follow up on labels Apr 17, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title ER from TLDL: ER from TLDL: Automated comment and labeling for issues with an open linked pr Apr 17, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title ER from TLDL: Automated comment and labeling for issues with an open linked pr ER from TLDL: Automate update comment and labeling for issues with an open linked pr Apr 17, 2023
@JessicaLucindaCheng JessicaLucindaCheng added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Apr 25, 2023
@ExperimentsInHonesty ExperimentsInHonesty added this to the 08. Team workflow milestone May 7, 2023
@t-will-gillis

This comment was marked as outdated.

@JessicaLucindaCheng

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added the Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level label Oct 10, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the ER Emergent Request label Oct 22, 2023
@JessicaLucindaCheng

This comment was marked as outdated.

@roslynwythe

This comment was marked as resolved.

@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng self-assigned this Nov 28, 2023

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Nov 28, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title ER from TLDL: Automate update comment and labeling for issues with an open linked pr ER: Automate update comment and labeling for issues with an open linked pr Feb 8, 2024
@JessicaLucindaCheng JessicaLucindaCheng added the Draft Issue is still in the process of being created label Feb 8, 2024
@JessicaLucindaCheng JessicaLucindaCheng added the GHA New Project Board compatible This GitHub Action issue does not reference columns and will work with the new board label Jun 18, 2024
@JessicaLucindaCheng JessicaLucindaCheng added the Draft Issue is still in the process of being created label Oct 8, 2024
@HackforLABot

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng removed their assignment Oct 8, 2024
@JessicaLucindaCheng JessicaLucindaCheng removed the Draft Issue is still in the process of being created label Oct 8, 2024
@JessicaLucindaCheng

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as resolved.

@HackforLABot

This comment was marked as outdated.

@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng added Issue Making: Level 4 Create an Epic Issue, and it's Level 2 or 3 issues and removed Issue Making: Level 2 Make issue(s) from an ER or Epic labels Nov 18, 2024
@JessicaLucindaCheng JessicaLucindaCheng changed the title ER: Automate update comment and labeling for issues with an open linked pr ER: Automate Update Comment and Labeling for Issues With an Open Linked PR Nov 18, 2024
@JessicaLucindaCheng JessicaLucindaCheng changed the title ER: Automate Update Comment and Labeling for Issues With an Open Linked PR ER: Counting Activities in a PR as Activity Credit in Its Linked Issue Nov 18, 2024
@JessicaLucindaCheng
Copy link
Member Author

@t-will-gillis

  1. Under the "Potential Solutions [Draft]", do you think all the issues in the "Counting Activities in a PR as Activity Credit in Its Linked Issue" section can be implemented/worked on at the same time?

  2. Can you please review this ER? If you think it's ready for prioritization, please add the label. Otherwise, let me know what changes you would like me to make.

Thanks.

@JessicaLucindaCheng JessicaLucindaCheng added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Draft Issue is still in the process of being created Complexity: Medium labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly GHA New Project Board compatible This GitHub Action issue does not reference columns and will work with the new board Issue Making: Level 4 Create an Epic Issue, and it's Level 2 or 3 issues ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Status: Emergent Requests
Development

No branches or pull requests

5 participants