-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor HTML displaying video without iframe #6353
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
When clicking on the share button from the Ted Talk website, the mp4 video file (325.6 MB) and mp3 audio file (7.5 MB) are available for download. If we save the actual files to the assets folder and use the video element, the iframe may be eliminated. For video files: For audio files: The share button, also provides the link and the code to embed the video:
|
@heejung-hong We don't have explicit permission to upload the video to our repository, and given that they have a copyright notice on their site, we can assume they are fine with people downloading or embeding but not anything else. Are any of the strategies on this page an option https://www.geeksforgeeks.org/alternative-to-iframes-in-html5/ I am moving this back to in progress. When you have a response, please leave another comment and put it in the questions column with a ready for dev lead label. |
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the You are receiving this comment because your last comment was before Tuesday, March 26, 2024 at 12:06 AM PST. |
Thank you for the information @ExperimentsInHonesty, I’ve looked at the other options and the embed and object elements work with the link to view the video. I have tested both on Chrome, Firefox, and Safari, in both mobile and tablet format, and did not encounter any issues in playing the video linked. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/embed
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/object
Unfortunately the video element didn’t work with the link.
I haven’t had any issues playing the video from my machine on all three browsers with the iframe element. In the mdn docs, it is indicated that frameborder and scrolling attributes are deprecated and should be removed from existing content. |
@heejung-hong Thank you for the information and testing of the
|
Hi @roslynwythe, I checked out the I would advise further testing for |
Thank you @heejung-hong for your analysis. We will be following up with a new issue to update the Events page based on your findings. |
Overview
We aim to find a new method for embedding the "Code for America" video within the header of the Events page, in order to resolve the problem some users have a loading the video due to their browsers' privacy (cross-site tracking prevention) settings.
Details
iframe
element, and browser privacy (tracking prevention) features may block loading content from tracking resources iniframe
elements.Action Items
_includes\events-page\header-container-content.html
Resources/Instructions
HTML for header of Events page
The text was updated successfully, but these errors were encountered: