Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Care Link in Credits Page #2131

Merged

Conversation

adrian-zaragoza
Copy link
Member

@adrian-zaragoza adrian-zaragoza commented Aug 20, 2021

Fixes #2093

What changes did you make and why did you make them ?

  • Updated title and alt to Care.
  • Updated artist to Bharat
  • Updated filename to care.yml

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions github-actions bot added P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers Size: Good second issue labels Aug 20, 2021
@github-actions
Copy link

From your project repository, check out a new branch and test the changes.

git checkout -b adrian-zaragoza-update-give-link-2093 gh-pages
git pull https://github.com/adrian-zaragoza/website.git update-give-link-2093

@JackRichman JackRichman self-requested a review August 20, 2021 07:39
Copy link
Member

@JackRichman JackRichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Nice job.

Copy link
Member

@macho-catt macho-catt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As @Aveline-art mentioned in the other PR, please only do one issue at a time and wait before your PR is merged before working on a new issue. Thanks!

@macho-catt macho-catt merged commit 0f7317e into hackforla:gh-pages Aug 21, 2021
@adrian-zaragoza adrian-zaragoza deleted the update-give-link-2093 branch August 27, 2021 18:30
@github-actions github-actions bot added Status: Updated No blockers and update is ready for review UAT: has visuals labels Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers Status: Updated No blockers and update is ready for review UAT: has visuals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ‘Give’ image credit link and information
4 participants