Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the profiles in the civic tech jobs project page #6818

Merged
merged 1 commit into from
May 4, 2024
Merged

Updates the profiles in the civic tech jobs project page #6818

merged 1 commit into from
May 4, 2024

Conversation

jonnyoe
Copy link
Member

@jonnyoe jonnyoe commented May 4, 2024

Fixes #6638

What changes did you make?

  • Removed Jen Chung, Melinda Sukosd, and Jenn Wu's profiles
  • Updated Lu Feng's profile and is after the other Product Managers' and Leads' profiles

Why did you make the changes (we will use this info to test)?

  • Keeps civic tech jobs project profiles and information up to date

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Screenshot 2024-05-03 at 11 50 45 PM

Visuals after changes are applied

Screenshot 2024-05-03 at 11 49 54 PM

@jonnyoe jonnyoe requested review from jphamtv and LRenDO May 4, 2024 06:53
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jono4727-update-profiles-6638 gh-pages
git pull https://github.com/jono4727/website.git update-profiles-6638

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 4, 2024
LRenDO
LRenDO approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jono4727!
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Changes appear correctly on the site
  • Relevant images were included to show visual changes
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made

Again, nice work and thanks for taking the time to contribute to the website!

@LRenDO LRenDO merged commit 1afdcdf into hackforla:gh-pages May 4, 2024
10 checks passed
@jphamtv jphamtv removed their request for review May 5, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LRenDO LRenDO LRenDO approved these changes

Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs (Remove Jen Chung, Melinda Sukosd, & Jenn Wu; Update Lu Feng)
2 participants
@jonnyoe @LRenDO