Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for marking items as non-export #45

Closed
W95Psp opened this issue Apr 14, 2023 · 4 comments
Closed

Add option for marking items as non-export #45

W95Psp opened this issue Apr 14, 2023 · 4 comments
Labels
cli Related to command line engine Issue in the engine frontend Issue in the Rust to JSON translation P2 Medium priority

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Apr 14, 2023

We should have both:

  • CLI options
  • Rust attributes

We should be able to express "everything but foo" and "nothing but foo" (at the module level)
@W95Psp W95Psp added frontend Issue in the Rust to JSON translation engine Issue in the engine cli Related to command line labels Apr 14, 2023
@franziskuskiefer franziskuskiefer moved this to Todo in hax Apr 14, 2023
@franziskuskiefer franziskuskiefer added the P2 Medium priority label Apr 14, 2023
W95Psp added a commit that referenced this issue May 31, 2023
@W95Psp
Add support for attributes & expn_data on items (fixes #49, fixes #88)
4404c01 
This also makes #45 trivial to implement
@W95Psp W95Psp mentioned this issue May 31, 2023
Merged
W95Psp added a commit that referenced this issue Jun 1, 2023
@W95Psp
Add support for attributes & expn_data on items (fixes #49, fixes #88)
94a6321 
This also makes #45 trivial to implement
bors bot added a commit that referenced this issue Jun 5, 2023
@bors @W95Psp
Merge #106
5b2752a 
106: Add support for attributes & expn_data on items (fixes #49, fixes #88) r=franziskuskiefer a=W95Psp

This also makes #45 trivial to implement

~This is draft because I removed the quick & dirty filter implemented in #94, thus I now need to restore the functionality.~
 - ~[ ] when we see an `impl` for a `Clone` derived by `core::clone::Clone`, replace it with an identity impl~
 - ~[ ] when we see an `impl` for a `Debug` derived by `core::fmt::macros::Debug`, replace it with a dummy impl (e.g. a constant string)~

I restored a filter similar to what I did in #94: we skip every automatically_dervied items. Issue #108 keeps track of the progress on writing a better filter, so that this PR is smaller.

Co-authored-by: Lucas Franceschino <lucas.franceschino@inria.fr>
bors bot added a commit that referenced this issue Jun 6, 2023
@bors @W95Psp
Merge #106
d279dcb 
106: Add support for attributes & expn_data on items (fixes #49, fixes #88) r=W95Psp a=W95Psp

This also makes #45 trivial to implement

~This is draft because I removed the quick & dirty filter implemented in #94, thus I now need to restore the functionality.~
 - ~[ ] when we see an `impl` for a `Clone` derived by `core::clone::Clone`, replace it with an identity impl~
 - ~[ ] when we see an `impl` for a `Debug` derived by `core::fmt::macros::Debug`, replace it with a dummy impl (e.g. a constant string)~

I restored a filter similar to what I did in #94: we skip every automatically_dervied items. Issue #108 keeps track of the progress on writing a better filter, so that this PR is smaller.

Co-authored-by: Lucas Franceschino <lucas.franceschino@inria.fr>
@franziskuskiefer
Copy link
Member

@W95Psp how does this relate to #211 ?

@W95Psp
Copy link
Collaborator Author

W95Psp commented Aug 21, 2023

I think that's actually a duplicate of #223, which I just added...

@W95Psp W95Psp mentioned this issue Aug 21, 2023
Closed
@W95Psp
Copy link
Collaborator Author

W95Psp commented Aug 21, 2023

Closed #223 in favor of that one

@W95Psp
Copy link
Collaborator Author

W95Psp commented Apr 18, 2024

Closing this, the feature is there in main.

@W95Psp W95Psp closed this as completed Apr 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in hax Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Related to command line engine Issue in the engine frontend Issue in the Rust to JSON translation P2 Medium priority
Projects
No open projects
hax
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@W95Psp @franziskuskiefer