Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt translation to early return question mark #564

Merged
merged 28 commits into from
Mar 19, 2024
Merged

Adapt translation to early return question mark #564

merged 28 commits into from
Mar 19, 2024

Conversation

jschneider-bensch
Copy link
Collaborator

@jschneider-bensch jschneider-bensch commented Mar 11, 2024 •
edited
Loading

This PR addresses #562.

It depends on changes in #550 and #559 so it is a draft until those are in.

jschneider-bensch and others added 18 commits March 7, 2024 14:28
@jschneider-bensch
Printers for ProVerif event definitions and emission terms
8597a6e
@jschneider-bensch
Define and emit reachability events at the beginning of letfuns
02c5a01
@jschneider-bensch
Formatting
c0206f9
@jschneider-bensch
Output more accurate comment for handwriting obligation
f87c202
@W95Psp
fix(engine/phases): DropSizedTrait: fix phase_id
e22747e
@W95Psp
feat(engine/phases): intro drop_needless_returns
9b30ed6
@W95Psp
feat(engine/phases): intro simplify_question_marks
a1053b0
@W95Psp
feat(engine/phases): intro simplify_match_return
4384912
@W95Psp
fix(engine): fix drop_needless_returns id
4ff7658
@W95Psp
fix(backends/fstar): use the new phases
4700d9c
@jschneider-bensch
Give only documents as arguments to pv_ print methods
95eac7a
@jschneider-bensch
Improve formatting of printed PV constructors
b046ec5
@jschneider-bensch
Add method for printing PV type declarations
fdb5e90
@jschneider-bensch
Add method for printin PV letfun declarations
1ae577b
@jschneider-bensch
Add method for printing PV letfun invocations
a35c4f8
@jschneider-bensch
Add helper methods for default and err letfuns
5e79ab4
@jschneider-bensch
Use defined helper methods
d5e4f53
@jschneider-bensch
Adapt PV translation to early return question marks
1535d80 
- Drop the `Result` wrapper in the `Ok` case
- `_err()` out in the case of `Err`
@jschneider-bensch jschneider-bensch mentioned this pull request Mar 12, 2024
Merged
@jschneider-bensch jschneider-bensch changed the base branch from main to jonas/more-bertie March 12, 2024 12:13
@jschneider-bensch jschneider-bensch changed the base branch from jonas/more-bertie to jonas/pv-macros-extract March 12, 2024 13:56
Base automatically changed from jonas/pv-macros-extract to main March 13, 2024 15:49
@jschneider-bensch jschneider-bensch marked this pull request as ready for review March 19, 2024 07:40
W95Psp
W95Psp approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but otherwise that looks good to me :)

engine/backends/proverif/proverif_backend.ml Outdated Show resolved Hide resolved
engine/backends/proverif/proverif_backend.ml Outdated Show resolved Hide resolved
@jschneider-bensch jschneider-bensch added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit 831dc88 Mar 19, 2024
11 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/pv-early-return-qmark branch March 19, 2024 14:03
@jschneider-bensch jschneider-bensch mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
hax
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschneider-bensch @W95Psp