Temporary fix for derived code (fixes #78)
#94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
approved these changes
May 23, 2023
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 23, 2023
94: Temporary fix for `derive`d code (fixes #78) r=franziskuskiefer a=W95Psp We want to skip derived implementations for `PartialEq`, `Eq`, `Clone`, `Debug`. This patch filters out every item that was automatically derived. This is a too coarse filter, we need to rework that. Co-authored-by: Lucas Franceschino <lucas.franceschino@inria.fr> Co-authored-by: Franziskus Kiefer <franziskuskiefer@gmail.com>
|
Build failed: |
|
@W95Psp looks like something is broken |
|
Yeah, some tests are failing because of some "Waiting for lock" messages.. Just fixed that, tests should pass now! |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
W95Psp
added a commit
that referenced
this pull request
May 31, 2023
W95Psp
added a commit
that referenced
this pull request
May 31, 2023
W95Psp
added a commit
that referenced
this pull request
Jun 1, 2023
bors bot
added a commit
that referenced
this pull request
Jun 5, 2023
106: Add support for attributes & expn_data on items (fixes #49, fixes #88) r=franziskuskiefer a=W95Psp This also makes #45 trivial to implement ~This is draft because I removed the quick & dirty filter implemented in #94, thus I now need to restore the functionality.~ - ~[ ] when we see an `impl` for a `Clone` derived by `core::clone::Clone`, replace it with an identity impl~ - ~[ ] when we see an `impl` for a `Debug` derived by `core::fmt::macros::Debug`, replace it with a dummy impl (e.g. a constant string)~ I restored a filter similar to what I did in #94: we skip every automatically_dervied items. Issue #108 keeps track of the progress on writing a better filter, so that this PR is smaller. Co-authored-by: Lucas Franceschino <lucas.franceschino@inria.fr>
bors bot
added a commit
that referenced
this pull request
Jun 6, 2023
106: Add support for attributes & expn_data on items (fixes #49, fixes #88) r=W95Psp a=W95Psp This also makes #45 trivial to implement ~This is draft because I removed the quick & dirty filter implemented in #94, thus I now need to restore the functionality.~ - ~[ ] when we see an `impl` for a `Clone` derived by `core::clone::Clone`, replace it with an identity impl~ - ~[ ] when we see an `impl` for a `Debug` derived by `core::fmt::macros::Debug`, replace it with a dummy impl (e.g. a constant string)~ I restored a filter similar to what I did in #94: we skip every automatically_dervied items. Issue #108 keeps track of the progress on writing a better filter, so that this PR is smaller. Co-authored-by: Lucas Franceschino <lucas.franceschino@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to skip derived implementations for
PartialEq,Eq,Clone,Debug. This patch filters out every item that was automatically derived. This is a too coarse filter, we need to rework that.