Improve error message for assertions of length 0 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +87,8 @@ check_result <- function(x) { | |||
| stop("assert_that: assertion must return a logical value", call. = FALSE) | |||
| if (any(is.na(x))) | |||
| stop("assert_that: missing values present in assertion", call. = FALSE) | |||
| if (length(x) == 0) | |||
| stop("assert_that: assertion has length 0", call. = FALSE) | |||
| if (length(x) > 1) { | |||
There was a problem hiding this comment.
How about just making this length(x) != 1 and updating the message accordingly
|
Done. Do you want we to squash the commits? |
hadley
added a commit
that referenced
this pull request
Mar 30, 2015
Improve error message for assertions of length 0
|
I don't care too much about a clean history for simple stuff like this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the error message when the assertion evaluates to a vector of length 0. Currently,
assertthatthrows