Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for assertions of length 0 #22

Merged
merged 2 commits into from
Mar 30, 2015
Merged

Improve error message for assertions of length 0 #22

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c369df
Add check for assertions of length 0
paulstaab Mar 30, 2015
2b3b8b9
Combine checks for assertion length
paulstaab Mar 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions R/assert-that.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ check_result <- function(x) {
stop("assert_that: assertion must return a logical value", call. = FALSE)
if (any(is.na(x)))
stop("assert_that: missing values present in assertion", call. = FALSE)
if (length(x) == 0)
stop("assert_that: assertion has length 0", call. = FALSE)
if (length(x) > 1) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just making this length(x) != 1 and updating the message accordingly

stop("assert_that: assertion has length greater than 1", call. = FALSE)
}
Expand Down