Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync HAFS submodules as of 12/06/2021 #118

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Conversation

BinLiu-NOAA
Copy link
Collaborator

@BinLiu-NOAA BinLiu-NOAA commented Dec 6, 2021

Description of changes

  • Point submodule hafs_forecast.fd to ufs-weather-model develop branch directly (as of 12/06/2021)
  • Point submodule hafs_post.fd to UPP develop branch directly (as of 12/06/2021)
  • Sync hafs_utils.fd with latest UFS_UTILS develop branch as of 12/06/2021

Issues addressed (optional)

If this PR addresses one or more issues, please provide link(s) to the issue(s) here.

Tests conducted

What testing has been conducted on the PR thus far? Describe the nature of any scientific or technical tests, including relevant details about the configuration(s) (e.g., cold versus warm start, number of cycles, forecast length, whether data assimilation was performed, etc). What platform(s) were used for testing?

Application-level regression test status

Running the HAFS application-level regression tests is currently performed by code reviewers after the developer creates the initial PR. As regression tests are conducted, the testers should use the checklist below to indicate successful regression tests. You may add other tests as needed. If a test fails, do not check the box. Instead, describe the failure in the PR comments, noting the platform where the test failed.

  • Jet
  • Hera
  • Orion
  • WCOSS Dell P3
  • WCOSS Cray

Again, as you helped previously, let's conduct the HAFS application/workflow level regression tests for this PR.
@evankalina, @panll, @mrinalbiswas (Hera and Orion)
@JunghoonShin-NOAA (Jet)
@LinZhu-NOAA (wcoss_dell_p3)
@BijuThomas-NOAA (wcoss_cray)

…as of 11/19/2021).

Sync hafs_utils.fd with latest UFS_UTILS develop branch as of 11/19/2021.
… directly (as of 12/06/2021)

*Point submodule hafs_post.fd to UPP develop branch directly (as of 12/06/2021)
@BinLiu-NOAA BinLiu-NOAA added the enhancement New feature or request label Dec 6, 2021
@BinLiu-NOAA BinLiu-NOAA marked this pull request as ready for review December 6, 2021 18:13
@BinLiu-NOAA BinLiu-NOAA self-assigned this Dec 6, 2021
@BinLiu-NOAA BinLiu-NOAA added Ready for Review The PR is considered complete by the author(s) Ready for RTs The PR is ready to conduct Regression Tests labels Dec 6, 2021
@JunghoonShin-NOAA
Copy link
Contributor

JunghoonShin-NOAA commented Dec 7, 2021

Hello Bin,
All regression tests of the hafs_sync_202112 branch were completed successfully on Jet. Especially, the wave (WW3) model part worked successfully at this time, which is very good news.
Thank you.

@LinZhu-NOAA
Copy link
Contributor

@BinLiu-NOAA The regression tests were completed successfully on WCOSS-DELL.

@mrinalbiswas
Copy link
Contributor

@BinLiu-NOAA RTs passed on Orion

@panll
Copy link
Contributor

panll commented Dec 8, 2021

RTs passed on Hera (slightly delayed by maintenance). @BinLiu-NOAA @evankalina

@BijuThomas-NOAA
Copy link
Contributor

The RTs were successfully completed on WCOSS-CRAY

@BinLiu-NOAA
Copy link
Collaborator Author

Thanks @JunghoonShin-NOAA, @LinZhu-NOAA, @mrinalbiswas, @panll and @BijuThomas-NOAA! Great that all HAFS application level regression tests went through smoothly on all five platforms. @evankalina, @KathrynNewman or @ZhanZhang-NOAA , please check and review this PR when you get a chance. Once it is approved, we can merge it into develop. Thanks!

Copy link
Contributor

@evankalina evankalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Glad we can point directly to the ufs-weather-model and UPP repositories now.

@BinLiu-NOAA BinLiu-NOAA added the Ready to Merge Review and RTs are all finished. The PR is ready to merge. label Dec 8, 2021
@BinLiu-NOAA BinLiu-NOAA merged commit 30666cc into develop Dec 8, 2021
@BinLiu-NOAA BinLiu-NOAA deleted the feature/hafs_sync_202112 branch January 26, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ready for Review The PR is considered complete by the author(s) Ready for RTs The PR is ready to conduct Regression Tests Ready to Merge Review and RTs are all finished. The PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to point UPP develop branch directly Switch to point ufs-weather-model develop branch directly
7 participants