-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync HAFS submodules as of 12/06/2021 #118
Conversation
…as of 11/19/2021). Sync hafs_utils.fd with latest UFS_UTILS develop branch as of 11/19/2021.
… directly (as of 12/06/2021) *Point submodule hafs_post.fd to UPP develop branch directly (as of 12/06/2021)
Hello Bin, |
@BinLiu-NOAA The regression tests were completed successfully on WCOSS-DELL. |
@BinLiu-NOAA RTs passed on Orion |
RTs passed on Hera (slightly delayed by maintenance). @BinLiu-NOAA @evankalina |
The RTs were successfully completed on WCOSS-CRAY |
Thanks @JunghoonShin-NOAA, @LinZhu-NOAA, @mrinalbiswas, @panll and @BijuThomas-NOAA! Great that all HAFS application level regression tests went through smoothly on all five platforms. @evankalina, @KathrynNewman or @ZhanZhang-NOAA , please check and review this PR when you get a chance. Once it is approved, we can merge it into develop. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. Glad we can point directly to the ufs-weather-model and UPP repositories now.
Description of changes
Issues addressed (optional)
If this PR addresses one or more issues, please provide link(s) to the issue(s) here.
Tests conducted
What testing has been conducted on the PR thus far? Describe the nature of any scientific or technical tests, including relevant details about the configuration(s) (e.g., cold versus warm start, number of cycles, forecast length, whether data assimilation was performed, etc). What platform(s) were used for testing?
Application-level regression test status
Running the HAFS application-level regression tests is currently performed by code reviewers after the developer creates the initial PR. As regression tests are conducted, the testers should use the checklist below to indicate successful regression tests. You may add other tests as needed. If a test fails, do not check the box. Instead, describe the failure in the PR comments, noting the platform where the test failed.
Again, as you helped previously, let's conduct the HAFS application/workflow level regression tests for this PR.
@evankalina, @panll, @mrinalbiswas (Hera and Orion)
@JunghoonShin-NOAA (Jet)
@LinZhu-NOAA (wcoss_dell_p3)
@BijuThomas-NOAA (wcoss_cray)