Handle title text overflow nicely?

[notatestuser]

A list item's description text uses text-overflow: ellipsis to clip overflow nicely when the content is longer than its allotted space. However, titles can clip off long words or wrap to new lines when they are long and contain spaces. This can look a bit funky in some places.

Proposal: Add a new attribute in SearchResult to apply text-overflow: ellipsis* on the title text. We would only want to do this optionally per plugin and not in all of them. It's still useful to wrap titles when calculating a long formula in hain-plugin-math, for instance.

res.add({
    // ...
    title: longTitle,
    singleLineTitle: true,  // <- applies text-overflow property to the title
    // ...
})

Example of long word clip:

Example of multi-line break:

* The actual styles we need to apply are something like:

text-overflow: ellipsis;
white-space: nowrap;
overflow-x: hidden;

I've experimented with this locally and it seems to work fine:

What do you think?

[appetizermonster]

Nice proposal, and I think it must be supported, but additional property for SearchResult isn't that nice.
I think we can find some better way.

[notatestuser]

OK. Do you think it could be at the plugin level?

[appetizermonster]

Maybe, but I have no confidence about it.
How do you think about the below one?

res.add({
  title: {   // can be String or Object
    text: 'single line text',
    singleLine: true
  },
  ...
});

[notatestuser]

That looks fine to me.

[appetizermonster]

Resolved at 84be796, needs docs

[notatestuser]

I had forgot to mention that my only concern is that the object form of the title is no longer backward compatible with previous versions. To work around this we could use a new name for the object form and continue to use a string title for older releases. What do you think?

[appetizermonster]

Oh, you don't need to worry about it. I wrote a code to support both string and object. so it has backward compatibility. no need to workaround.

[notatestuser]

I see. And a new plugin in an older hain will not produce problems either?

[appetizermonster]

No, Sorry, I misunderstood. new plugin with new API will not be listed in older hain if they write new API version in package.json or they can handle it by using appContext.CURRENT_API_VERSION.

[notatestuser]

That's great - thanks.

[notatestuser]

The titles appear to hit the text-util as strings of [object Object]. Is react stringifying them?

[notatestuser]

Bump @appetizermonster 😉

[appetizermonster]

@notatestuser Oh sorry, I'll make a patch for it soon.

[notatestuser]

Thanks!

Get Outlook for iOS

On Thu, Jun 16, 2016 at 10:53 AM +0800, "Heejin Lee" notifications@github.com wrote:

@notatestuser Oh sorry, I'll make a patch for it soon.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[appetizermonster]

Resolved at 202287c

[notatestuser]

Great! Please bump up the API version in the next release so I can target this fix. Thanks. 😄

[appetizermonster]

Okay, I'll

[notatestuser]

Hey, do you have any idea when this will be released?

[appetizermonster]

@notatestuser Sorry for late, I'm so busy for my work these days, I think it will be released with several another additions in at least two weeks.

[notatestuser]

Bump. I would really like to see this fixed. 😃