From 6c432d25277343a523f01a03cc69ea9ab4325fa8 Mon Sep 17 00:00:00 2001
From: Steven Johnson <srj@google.com>
Date: Wed, 29 Jun 2022 15:34:16 -0700
Subject: [PATCH] Change stub module names in Python to be _pystub rather than
 _stub

This is a bit finicky, but making this the default nomenclature will make some downstream usages less ambiguous and a bit easier to manage. (Yes, I realize that #6821 removes the Makefile entirely, but until it lands, it needs fixing there too.)
---
 python_bindings/Makefile                             | 12 ++++++------
 .../correctness/generators/CMakeLists.txt            |  2 +-
 python_bindings/correctness/pystub.py                | 10 +++++-----
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/python_bindings/Makefile b/python_bindings/Makefile
index 73f60afbda84..4b59feaa7ca1 100644
--- a/python_bindings/Makefile
+++ b/python_bindings/Makefile
@@ -95,7 +95,7 @@ $(BIN)/%_generator.o: $(ROOT_DIR)/correctness/generators/%_generator.cpp $(HALID
 # In our build files here, we build both kinds of extension for every Generator in the generators/
 # directory (even though not all are used). As a simplistic way to distinguish between the two
 # sorts of extensions, we use the unadorned Generator name for AOT extensions, and the Generator name
-# suffixed with "_stub" for Stub extensions. (TODO: this is unsatisfyingly hackish; better suggestions
+# suffixed with "_pystub" for Stub extensions. (TODO: this is unsatisfyingly hackish; better suggestions
 # would be welcome.)
 
 $(BIN)/PyStubImpl.o: $(ROOT_DIR)/stub/PyStubImpl.cpp $(HALIDE_DISTRIB_PATH)/include/Halide.h
@@ -186,21 +186,21 @@ $(BIN)/aot/%.so: $(BIN)/%.py.o $(BIN)/%.a $(BIN)/runtime.a $(BIN)/%.ldscript
 # Compiling PyStub.cpp, then linking with the generator's .o file, PyStubImpl.o, plus the same libHalide
 # being used by halide.so.
 #
-# Note that we set HALIDE_PYSTUB_MODULE_NAME to $*_stub (e.g. foo_stub) but
+# Note that we set HALIDE_PYSTUB_MODULE_NAME to $*_pystub (e.g. foo_pystub) but
 # set HALIDE_PYSTUB_GENERATOR_NAME to the unadorned name of the Generator.
 $(BIN)/%_PyStub.o: $(ROOT_DIR)/stub/PyStub.cpp
 	@echo Building $@...
 	@mkdir -p $(@D)
-	@$(CXX) $(CCFLAGS) -DHALIDE_PYSTUB_MODULE_NAME=$*_stub -DHALIDE_PYSTUB_GENERATOR_NAME=$* -c $< -o $@
+	@$(CXX) $(CCFLAGS) -DHALIDE_PYSTUB_MODULE_NAME=$*_pystub -DHALIDE_PYSTUB_GENERATOR_NAME=$* -c $< -o $@
 
-$(BIN)/stub/%_stub.so: $(BIN)/%_PyStub.o $(BIN)/PyStubImpl.o $(BIN)/%_generator.o $(BIN)/%_stub.ldscript $(LIBHALIDE)
+$(BIN)/stub/%_pystub.so: $(BIN)/%_PyStub.o $(BIN)/PyStubImpl.o $(BIN)/%_generator.o $(BIN)/%_pystub.ldscript $(LIBHALIDE)
 	@echo Building $@...
 	@mkdir -p $(@D)
-	@$(CXX) $(LDFLAGS) $(filter-out %.ldscript,$^) -shared $(subst %LDSCRIPT%,$(BIN)/$*_stub.ldscript,$(PYEXT_LDSCRIPT_FLAG)) -o $@
+	@$(CXX) $(LDFLAGS) $(filter-out %.ldscript,$^) -shared $(subst %LDSCRIPT%,$(BIN)/$*_pystub.ldscript,$(PYEXT_LDSCRIPT_FLAG)) -o $@
 
 GENERATOR_SRCS=$(shell ls $(ROOT_DIR)/correctness/generators/*_generator.cpp)
 GENERATOR_AOT_EXTENSIONS=$(GENERATOR_SRCS:$(ROOT_DIR)/correctness/generators/%_generator.cpp=$(BIN)/aot/%.so)
-GENERATOR_STUB_EXTENSIONS=$(GENERATOR_SRCS:$(ROOT_DIR)/correctness/generators/%_generator.cpp=$(BIN)/stub/%_stub.so)
+GENERATOR_STUB_EXTENSIONS=$(GENERATOR_SRCS:$(ROOT_DIR)/correctness/generators/%_generator.cpp=$(BIN)/stub/%_pystub.so)
 
 APPS = $(shell ls $(ROOT_DIR)/apps/*.py)
 CORRECTNESS = $(shell ls $(ROOT_DIR)/correctness/*.py)
diff --git a/python_bindings/correctness/generators/CMakeLists.txt b/python_bindings/correctness/generators/CMakeLists.txt
index 85590419a677..8fcfb0734601 100644
--- a/python_bindings/correctness/generators/CMakeLists.txt
+++ b/python_bindings/correctness/generators/CMakeLists.txt
@@ -36,5 +36,5 @@ foreach (GEN IN LISTS GENERATORS)
     add_python_stub_extension(py_stub_${GEN}
                               SOURCES ${GEN}_generator.cpp
                               GENERATOR ${GEN}
-                              MODULE ${GEN}_stub)
+                              MODULE ${GEN}_pystub)
 endforeach ()
diff --git a/python_bindings/correctness/pystub.py b/python_bindings/correctness/pystub.py
index a48d7a7d16ec..67941193a80b 100644
--- a/python_bindings/correctness/pystub.py
+++ b/python_bindings/correctness/pystub.py
@@ -1,8 +1,8 @@
 
 import halide as hl
 
-import simple_stub
-import complex_stub
+import simple_pystub
+import complex_pystub
 
 def _realize_and_check(f, offset = 0):
     b = hl.Buffer(hl.Float(32), [2, 2])
@@ -284,6 +284,6 @@ def test_complex(gen):
             assert expected == actual, "Expected %s Actual %s" % (expected, actual)
 
 if __name__ == "__main__":
-    test_simple(simple_stub.generate)
-    test_looplevel(simple_stub.generate)
-    test_complex(complex_stub.generate)
+    test_simple(simple_pystub.generate)
+    test_looplevel(simple_pystub.generate)
+    test_complex(complex_pystub.generate)