Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes not to initialize extensions in the plugin properly #5226

Closed
JohnNiang opened this issue Jan 22, 2024 · 0 comments · Fixed by #5251
Closed

Sometimes not to initialize extensions in the plugin properly #5226

JohnNiang opened this issue Jan 22, 2024 · 0 comments · Fixed by #5251
Assignees
@JohnNiang
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
2.12.0

Comments

@JohnNiang
Copy link
Member

System information

  • 外部访问地址:
  • 启动时间: 2024-01-21 22:48
  • 版本:
  • 构建时间:
  • Git Commit:
  • Java: OpenJDK Runtime Environment / 17.0.6+10
  • 数据库: H2 / 2.2.224
  • 操作系统: Mac OS X / 14.2.1

What is the project operation method?

Source Code

Your site address.

localhost

What happened?

After refactoring plugin reconciler in #5148, the extensions in the plugin fail to initialize sometimes, especially when updating the plugin.

Relevant log output

No response

Additional information

/assign
@JohnNiang JohnNiang added the kind/bug Categorizes issue or PR as related to a bug. label Jan 22, 2024
@JohnNiang JohnNiang added this to the 2.12.x milestone Jan 22, 2024
This was referenced Jan 23, 2024
Closed
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Jan 26, 2024
@JohnNiang
Simplify halo plugin manager (#5251)
8288e4e 
#### What type of PR is this?

/kind improvement
/area core
/area plugin
/milestone 2.12.x

#### What this PR does / why we need it:

This PR mainly simplifies halo plugin manager. Before this,
- we have too many repeat code from super class, which is uncessary
- we maintain plugin application context in ExtensionComponentsFinder, which is uncessary and is hard to manage
- we fire halo plugin event in halo plugin manager, which is complicated and leads to too many repeat code

This PR does:
- refactor halo plugin manager
- wrap base plugin with spring plugin which contains application context
- remove ExtensionComponentsFinder
- bridge halo plugin event and spring plugin event
- wait extensions fully deleted when stopping

Meanwhile, this PR will supersede PR <#5236>.

#### Which issue(s) this PR fixes:

Fixes #5226

#### Special notes for your reviewer:

Test installing, enabing, disabling, upgrading, reloading and deleting plugins.

#### Does this PR introduce a user-facing change?

```release-note
None
```
@JohnNiang JohnNiang modified the milestones: 2.12.x, 2.12.0 Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnNiang JohnNiang

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.12.0
1 participant
@JohnNiang