Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown options cannot be clicked in some mobile devices #4116

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 25, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.7.x

What this PR does / why we need it:

修复在部分移动端浏览器(比如 iOS Safari)中,下拉框组件(VDropdown)的选项点击无效的问题,即没有触发 click 事件。此问题的原因可能是因为我们用的 floating-vue 组件提供的 v-close-popper 指令的兼容问题,最小复现:https://stackblitz.com/edit/vitejs-vite-ncpzhj?file=src%2FApp.vue

此 PR 改写了关闭下拉框的方式,不再使用 v-close-popper 指令,而且对其他使用此组件的地方没有破坏性更新。

Which issue(s) this PR fixes:

Fixes #3689
Ref #2699

Special notes for your reviewer:

如果有条件可以在移动端测试一下,尤其是 iOS Safari,目前在桌面端 Chrome 的设备模拟中测试正常。

Does this PR introduce a user-facing change?

修复 Console 端的下拉框组件选项在移动端无法正常点击的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Jun 25, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.7.x milestone Jun 25, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wzrove June 25, 2023 06:02
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #4116 (b95cb6c) into main (96225e4) will increase coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4116      +/-   ##
============================================
+ Coverage     60.34%   60.48%   +0.14%     
- Complexity     2392     2397       +5     
============================================
  Files           359      359              
  Lines         12393    12393              
  Branches        892      892              
============================================
+ Hits           7478     7496      +18     
+ Misses         4478     4459      -19     
- Partials        437      438       +1     

see 5 files with indirect coverage changes

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 27ef8d3 into halo-dev:main Jun 26, 2023
@ruibaby ruibaby modified the milestones: 2.7.x, 2.7.0 Jun 26, 2023
@ruibaby ruibaby deleted the fix/auto-hide-dropdown branch November 18, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

移动端后台带3个点的设置都无法进行
3 participants