Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the styles of the data list filter area on the mobile devices #4587

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 11, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.10.x

What this PR does / why we need it:

改进移动设备上数据列表过滤器区域的样式。

before:

image

after:

image

Which issue(s) this PR fixes:

Ref #2699

Does this PR introduce a user-facing change?

改进 Console 端在移动设备上数据列表过滤器区域的样式。

…evices

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Sep 11, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 11, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Sep 11, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wan92hen September 11, 2023 04:36
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #4587 (bee9563) into main (e13563b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4587   +/-   ##
=========================================
  Coverage     61.04%   61.04%           
  Complexity     2566     2566           
=========================================
  Files           374      374           
  Lines         13168    13168           
  Branches        938      938           
=========================================
  Hits           8039     8039           
  Misses         4676     4676           
  Partials        453      453           

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
👍

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 83cb088 into halo-dev:main Sep 14, 2023
2 checks passed
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 20, 2023
f2c-ci-robot bot pushed a commit to halo-dev/plugin-s3 that referenced this pull request Oct 16, 2023
…evices (#87)

同步 <halo-dev/halo#4587> 中的数据列表过滤器区域的样式改进。
```release-note
同步移动设备上数据列表过滤器区域的样式改进
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants