-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TOTP two-factor authentication #4737
Conversation
Hi @ruibaby ,似乎缺失 2FA 页面的 UI。 |
想想咋整,如果用页面提供,会影响原来登录失效弹框的流程。 |
暂时不考虑页面提供吧。按照目前提供的登录页面和登录弹窗单独适配即可。 |
Hi @ruibaby , I find it difficult to resolve conflicts involved in the console, please help me resolve them before continuing. ❤️ |
Okay,I will reset and then place it in the user center. |
f960a5d
to
75cd29c
Compare
/retitle Support TOTP two-factor authentication Ready for review |
Signed-off-by: John Niang <johnniang@foxmail.com>
Signed-off-by: John Niang <johnniang@foxmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4737 +/- ##
============================================
- Coverage 56.47% 55.98% -0.50%
- Complexity 3003 3027 +24
============================================
Files 525 538 +13
Lines 17614 17973 +359
Branches 1304 1319 +15
============================================
+ Hits 9948 10062 +114
- Misses 7126 7367 +241
- Partials 540 544 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
...rc/main/java/run/halo/app/security/authentication/twofactor/totp/DefaultTotpAuthService.java
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
/area core
What this PR does / why we need it:
See #4541 for more.
Which issue(s) this PR fixes:
Fixes #4541
Special notes for your reviewer:
Does this PR introduce a user-facing change?