-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pref: add additional attributes and colgroup for tables #5176
Conversation
@LIlGG: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold 需要等待 #5173 合并 |
createColGroup 包并没有包含在 tiptap 2.1.x 版本包中,因此需要等待 tiptap 发布 2.2.x 版本后。 |
可以考虑升级至 https://github.com/ueberdosis/tiptap/releases/tag/v2.2.0-rc.8。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
滚动问题可能和这个 issue 有关 #5182,帮忙确认不是此 pr 的问题 |
…der-table-colgroup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5176 +/- ##
=========================================
Coverage 56.47% 56.47%
Complexity 3003 3003
=========================================
Files 525 525
Lines 17614 17614
Branches 1304 1304
=========================================
Hits 9948 9948
Misses 7126 7126
Partials 540 540 ☔ View full report in Codecov by Sentry. |
console 端滚动问题将在 #5182 中进行解决。
已经提交新的 commit 修复此问题。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind improvmenet /area editor /milestone 2.12.x 为默认编辑器 table 组件渲染后的结果中增加 `colgroup`,并为 table 增加 `width` 与 `minWidth` 属性。 用于解决渲染完成之后的 table html 宽度与编辑时不一致的问题。 拖拽修改默认编辑器表格列宽,查看生成后的 html 列宽是否同样发生了变化,并且查看生成的 html 结构下是否具有 `colgroup` html 元素。 Fixes halo-dev#5138 ```release-note 为默认富文本编辑器 table 组件渲染后的 html 增加 colgroup 元素与 width 属性 ``` feat: add search and replace feat: add search and replace feat: add search and replace feat: add search and replace feat: add search and replace feat: add search and replace
What type of PR is this?
/kind improvmenet
/area editor
/milestone 2.12.x
What this PR does / why we need it:
为默认编辑器 table 组件渲染后的结果中增加
colgroup
,并为 table 增加width
与minWidth
属性。用于解决渲染完成之后的 table html 宽度与编辑时不一致的问题。
How to test it?
拖拽修改默认编辑器表格列宽,查看生成后的 html 列宽是否同样发生了变化,并且查看生成的 html 结构下是否具有
colgroup
html 元素。Which issue(s) this PR fixes:
Fixes #5138
Does this PR introduce a user-facing change?