Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump tiptap version to 2.1.16 #5210

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 19, 2024

What type of PR is this?

/area console
/area editor
/milestone 2.12.x
/kind bug

What this PR does / why we need it:

升级 tiptap 相关依赖,解决代码块中换行的问题。

Which issue(s) this PR fixes:

Fixes #5207

Special notes for your reviewer:

测试方式:

  1. 进入 console/packages/editor,更新依赖
  2. 使用 pnpm dev 启动编辑器服务
  3. 插入一个代码块,然后刷新页面,观察代码块是否显示正常

Does this PR introduce a user-facing change?

None

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note-none Denotes a PR that doesn't merit a release note. labels Jan 19, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 19, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Jan 19, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 19, 2024
@LIlGG
Copy link
Member

LIlGG commented Jan 19, 2024

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a37df0) 57.06% compared to head (93ee9bd) 57.06%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5210   +/-   ##
=========================================
  Coverage     57.06%   57.06%           
  Complexity     3333     3333           
=========================================
  Files           584      584           
  Lines         19190    19190           
  Branches       1444     1444           
=========================================
  Hits          10950    10950           
  Misses         7664     7664           
  Partials        576      576           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby changed the title chore: bump tiptap version to 2.1.6 chore: bump tiptap version to 2.1.16 Jan 19, 2024
Copy link

f2c-ci-robot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit df8bb33 into halo-dev:main Jan 19, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Jan 19, 2024
@ruibaby ruibaby deleted the chore/bump-tiptap-version-2.1.16 branch March 24, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

代码块在保存之后会被压缩
3 participants