Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hooking user creation #6945

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind feature
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR adds support for hooking user creating. Plugin developers can define extension points of UserPreCreatingHandler and UserPostCreatingHandler to do something else.

Does this PR introduce a user-facing change?

支持在插件中定义用户创建的前置和后置处理器

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 25, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 25, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 25, 2024
Copy link

sonarcloud bot commented Oct 25, 2024

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (eff73dc) to head (cb2107f).
Report is 37 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6945      +/-   ##
============================================
+ Coverage     56.99%   57.23%   +0.23%     
- Complexity     3999     4005       +6     
============================================
  Files           714      712       -2     
  Lines         24110    24123      +13     
  Branches       1585     1588       +3     
============================================
+ Hits          13742    13806      +64     
+ Misses         9756     9704      -52     
- Partials        612      613       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang
Copy link
Member Author

I'm going to merge this PR as quick as possible for a quick verification.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
Copy link

f2c-ci-robot bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit a0b352a into halo-dev:main Oct 25, 2024
8 checks passed
@JohnNiang JohnNiang deleted the feat/before-signup branch October 25, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants