Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to configure and use image thumbnails #167

Merged
merged 4 commits into from
Sep 26, 2024
Merged

feat: ability to configure and use image thumbnails #167

merged 4 commits into from
Sep 26, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Aug 12, 2024 •
edited
Loading

What this PR does?

适配 Halo 2.19（WIP） 的缩略图机制支持 S3 配置并使用缩略图

缩略图规则参考：

支持配置并使用图片缩略图机制

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from minliacom and ruibaby August 12, 2024 08:38
@guqing
Copy link
Member Author

guqing commented Aug 12, 2024

Wait for halo-dev/halo#6454 (comment) to be merged

@guqing guqing force-pushed the feature/thumbnail branch from 1250cc5 to 69ed005 Compare August 29, 2024 03:26
@guqing guqing changed the title [WIP] feat: ability to configure and use image thumbnails feat: ability to configure and use image thumbnails Sep 3, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 3, 2024
JohnNiang
JohnNiang reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要同步修改一下插件所需 Halo 最低版本要求：

plugin-s3/src/main/resources/plugin.yaml

Line 7 in 97f653b

requires: ">=2.17.0"

@guqing
Copy link
Member Author

guqing commented Sep 19, 2024

需要同步修改一下插件所需 Halo 最低版本要求：

plugin-s3/src/main/resources/plugin.yaml

Line 7 in 97f653b

requires: ">=2.17.0"

Done

JohnNiang
JohnNiang approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ping @halo-dev/sig-halo
/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
ruibaby
ruibaby approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 68b0bee into main Sep 26, 2024
2 checks passed
@ruibaby ruibaby deleted the feature/thumbnail branch September 26, 2024 07:46
@guqing guqing mentioned this pull request Sep 27, 2024
Open
@guqing guqing mentioned this pull request Oct 14, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Oct 14, 2024
@guqing
chore: update requires to 2.20.0 (#171)
a791926 
### What this PR does?
将 requires 改动到 2.20.0
目前 Halo 2.20.0 已经发布，此 #167 功能需要在 2.20.0 才能完整工作，因此升级到此版本后准备发版

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longjuan longjuan longjuan left review comments

@ruibaby ruibaby ruibaby approved these changes

@JohnNiang JohnNiang JohnNiang approved these changes

@minliacom minliacom Awaiting requested review from minliacom

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guqing @JohnNiang @ruibaby @longjuan