Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDEA] Implement transactions #95

Open
halvardssm opened this issue Feb 27, 2021 · 1 comment
Open

[IDEA] Implement transactions #95

halvardssm opened this issue Feb 27, 2021 · 1 comment
Labels
idea New idea for the project

Comments

@halvardssm
Copy link
Owner

halvardssm commented Feb 27, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
When running a migration, it should start a transaction as default, unless this is disabled in config. The transaction should also be possible to commit in migration file, and to start new transaction. This will allow the migration to not make any changes in case of errors.

Describe the solution you'd like
Utilize the transaction interface from the clients when making a migration.

Additional context
https://github.com/denodrivers/mysql#transaction

Consider delaying this until jeremyBanks/database#9 is implemented across databases?
@halvardssm halvardssm added the idea New idea for the project label Feb 27, 2021
@halvardssm halvardssm self-assigned this Feb 27, 2021
@halvardssm halvardssm added this to the v2 milestone Apr 11, 2021
@halvardssm halvardssm removed their assignment May 17, 2021
@halvardssm halvardssm removed this from the v2 milestone May 23, 2021
@suneg
Copy link

suneg commented Jan 9, 2022

This would be really useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea New idea for the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@suneg @halvardssm