From 9cb1b22d748b6fde27cbbcdb96dbc21e58599d6a Mon Sep 17 00:00:00 2001 From: han0110 Date: Mon, 29 Jan 2024 10:06:56 +0000 Subject: [PATCH] fix: add a FIXME for quotient poly blinding --- halo2_alt/src/backend/fflonk/prover.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/halo2_alt/src/backend/fflonk/prover.rs b/halo2_alt/src/backend/fflonk/prover.rs index 35ae64e687..68bd54b8b5 100644 --- a/halo2_alt/src/backend/fflonk/prover.rs +++ b/halo2_alt/src/backend/fflonk/prover.rs @@ -90,6 +90,10 @@ where advice_values.extend(values); advice_cosets.extend(cosets); + // FIXME: Currently there is no blinding factors for quotient polynomials, but in fflonk we + // might have redudant rotated queries to quotient polynomials for verifier to + // recover the actual evaluations of combined polynomials, which might break the + // zero-knowledge property. let quotient_polys = { let dummy_coset = Polynomial::new(Vec::new()); let polys = chain![