chore: slice append replace loop (#588)

hanchuanchuan · May 2, 2024 · b0cdd35 · b0cdd35
1 parent 02acf74
commit b0cdd35
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/planner/core/rule_predicate_push_down.go b/planner/core/rule_predicate_push_down.go
@@ -75,9 +75,7 @@ func (p *LogicalSelection) PredicatePushDown(predicates []expression.Expression)
 func (p *LogicalUnionScan) PredicatePushDown(predicates []expression.Expression) ([]expression.Expression, LogicalPlan) {
 	retainedPredicates, _ := p.children[0].PredicatePushDown(predicates)
 	p.conditions = make([]expression.Expression, 0, len(predicates))
-	for _, cond := range predicates {
-		p.conditions = append(p.conditions, cond)
-	}
+	p.conditions = append(p.conditions, predicates...)
 	// The conditions in UnionScan is only used for added rows, so parent Selection should not be removed.
 	return retainedPredicates, p
 }
@@ -317,9 +315,7 @@ func (p *LogicalProjection) PredicatePushDown(predicates []expression.Expression
 func (p *LogicalUnionAll) PredicatePushDown(predicates []expression.Expression) (ret []expression.Expression, retPlan LogicalPlan) {
 	for i, proj := range p.children {
 		newExprs := make([]expression.Expression, 0, len(predicates))
-		for _, cond := range predicates {
-			newExprs = append(newExprs, cond)
-		}
+		newExprs = append(newExprs, predicates...)
 		retCond, newChild := proj.PredicatePushDown(newExprs)
 		addSelection(p, newChild, retCond, i)
 	}

diff --git a/store/mockstore/mocktikv/executor.go b/store/mockstore/mocktikv/executor.go
@@ -566,9 +566,7 @@ func (e *topNExec) evalTopN(value [][]byte) error {
 	}
 
 	if e.heap.tryToAddRow(newRow) {
-		for _, val := range value {
-			newRow.data = append(newRow.data, val)
-		}
+		newRow.data = append(newRow.data, value...)
 	}
 	return errors.Trace(e.heap.err)
 }