Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

能否支持一些alter ddl操作不需调用osc的禁止调用 #258

Closed
zwunix opened this issue Aug 18, 2020 · 6 comments
Closed

能否支持一些alter ddl操作不需调用osc的禁止调用 #258

zwunix opened this issue Aug 18, 2020 · 6 comments
Labels
wontfix This will not be worked on

Comments

@zwunix
Copy link

zwunix commented Aug 18, 2020

描述您想要的功能:
在osc默认开启的情况下,能否增加支持一些alter ddl操作不需调用osc的禁止调用。比如alter字符集,alter drop index等。

@stale
Copy link

stale bot commented Sep 1, 2020

由于此问题没有最近的活动,因此已被自动标记为陈旧。如果没有进一步的活动,会作为不活跃issue关闭。感谢你对本项目的贡献。 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 1, 2020
@hanchuanchuan
Copy link
Owner

我测试了一下, 只有以下几种写法是完全不会锁表的.

ALTER TABLE tbl_name CHARACTER SET = charset_name;
ALTER TABLE tbl_name COLLATE = 'utf8_bin';
ALTER TABLE tbl_name COMMENT = '...';

接下来这几种操作如果是单个操作的话会跳过调用OSC, 并计划添加一个自定义选项来设置想要跳过的alter table子句.

@stale stale bot removed the wontfix This will not be worked on label Sep 1, 2020
@zwunix
Copy link
Author

zwunix commented Sep 2, 2020

hanchuanchuan added a commit that referenced this issue Sep 6, 2020
feature: 添加参数ignore_osc_alter_stmt可配置忽略osc的alter子句 (#258)
@hanchuanchuan
Copy link
Owner

已添加参数ignore_osc_alter_stmt, 可配置强制忽略osc的Alter子句, 直接执行.

Releases (选择v1.2.3-26或以上版本)

格式为drop index,add column等,配置要跳过的子句格式,多个时以逗号分隔

ignore_osc_alter_stmt = 'add index,drop index'

以下格式的语法已自动跳过osc:

ALTER TABLE tbl_name CHARACTER SET = charset_name;
ALTER TABLE tbl_name COLLATE = 'utf8_bin';
ALTER TABLE tbl_name COMMENT = '...';

@zwunix
Copy link
Author

zwunix commented Sep 6, 2020 via email

@stale
Copy link

stale bot commented Sep 20, 2020

由于此问题没有最近的活动,因此已被自动标记为陈旧。如果没有进一步的活动,会作为不活跃issue关闭。感谢你对本项目的贡献。 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 20, 2020
@stale stale bot closed this as completed Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants