added default rasterization to scatter_plot_2d() #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello all! Have created a new pull request for rasterizing scatter plots (and maybe other plot kinds too) as increasingly they take a long time to load on certain pdf viewers. This is an old pr but I accidentally closed the other one (lol). The rasterize setting is now embedded deeper in the code (in anesthetic/plot.py in the scatter_plot_2d() function) and rasterizing scatters has been made the default. I've also done away with z_orders as they were a bit awkward and I don't think we need them if we just use the matplotlib keyword argument 'rasterized'? Does anyone see an issue with doing it this way? Let me know your thoughts!
Fixes # (issue)
Checklist:
flake8 anesthetic tests
)pydocstyle --convention=numpy anesthetic
)python -m pytest
)