syncRowWithRawSource, in the NestedRows Plugin, always returns null for upmostParent

[sebworks2024]

Describe the bug

While looking at the nested rows code I noticed the syncRowWithRawSource has code which will always return null for the utmost parent.

Video/Screenshots

No response

Provide a link to the demo with the bug reproduction

No response

Handsontable version

15

Framework version

No response

Your environment

os x

[adrianszymanski89]

Hi @sebworks2024

Can you please add a little bit more context to this issue?

[sebworks2024]

@adrianszymanski89 , the issue affects moving nested rows.

Doesn't work:

syncRowWithRawSource(rowElement) {
    let upmostParent = rowElement;
    let tempParent = null;

    do {
      tempParent = this.getRowParent(tempParent);

      if (tempParent !== null) {
        upmostParent = tempParent;
      }

    } while (tempParent !== null);

    this.plugin.disableCoreAPIModifiers();
    this.hot.setSourceDataAtCell(
      this.getRowIndex(upmostParent),
      '__children',
      upmostParent.__children,
      'NestedRows.syncRowWithRawSource',
    );
    this.plugin.enableCoreAPIModifiers();
  }

Works:

syncRowWithRawSource(rowElement) {
    let upmostParent = rowElement;
    **let tempParent = upmostParent;**

    do {
      tempParent = this.getRowParent(tempParent);

      if (tempParent !== null) {
        upmostParent = tempParent;
      }

    } while (tempParent !== null);

    this.plugin.disableCoreAPIModifiers();
    this.hot.setSourceDataAtCell(
      this.getRowIndex(upmostParent),
      '__children',
      upmostParent.__children,
      'NestedRows.syncRowWithRawSource',
    );
    this.plugin.enableCoreAPIModifiers();
  }

[adrianszymanski89]

@sebworks2024

Thank you. I can see that you already also created a PR for this issue. We appreciate it.