Skip to content

implementation of getComputedStyle method is no longer available in Handsontable.dom but remains in type file #11394

Closed
@hjbolide

Description

@hjbolide

Describe the bug

I noticed in file:
https://github.com/handsontable/handsontable/blob/15.0.0/handsontable/src/helpers/dom/element.js

There used to be an implementation of method getComputedStyle in previous release:
https://github.com/handsontable/handsontable/blob/14.6.1/handsontable/src/helpers/dom/element.js

It seems to me there's no longer a need for this method due to refactory in v15, however in:
https://github.com/handsontable/handsontable/blob/15.0.0/handsontable/types/helpers/dom/element.d.ts

The method is still listed.

Suggest to remove the type definition of this method, and also add this to breaking changes, as it is, by definition, a breaking change if anyone used to use Handsontable.dom.getComputedStyle(this.TD, this.hot.rootWindow) (like us).

Thank you,
Charles

Video/Screenshots

No response

Provide a link to the demo with the bug reproduction

No response

Handsontable version

v15.0.0

Framework version

Angular 18

Your environment

Chrome, Firefox, Safari

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions