forked from swiftlang/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[analyzer][HTMLRewriter] Cache partial rewrite results. (llvm#80220)
This is a follow-up for 721dd3b [analyzer] NFC: Don't regenerate duplicate HTML reports. Because HTMLRewriter re-runs the Lexer for syntax highlighting and macro expansion purposes, it may get fairly expensive when the rewriter is invoked multiple times on the same file. In the static analyzer (which uses HTMLRewriter for HTML output mode) we only get away with this because there are usually very few reports emitted per file. But if loud checkers are enabled, such as `webkit.*`, this may explode in complexity and even cause the compiler to run over the 32-bit SourceLocation addressing limit. This patch caches intermediate results so that re-lexing only needed to happen once. As the clever __COUNTER__ test demonstrates, "once" is still too many. Ideally we shouldn't re-lex anything at all, which remains a TODO.
- Loading branch information
Showing
4 changed files
with
162 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// RUN: rm -fR %t | ||
// RUN: mkdir %t | ||
// RUN: %clang_analyze_cc1 -analyzer-checker=core \ | ||
// RUN: -analyzer-output=html -o %t -verify %s | ||
// RUN: grep -v CHECK %t/report-*.html | FileCheck %s | ||
|
||
|
||
void foo() { | ||
int *x = 0; | ||
*x = __COUNTER__; // expected-warning{{Dereference of null pointer (loaded from variable 'x')}} | ||
} | ||
|
||
void bar() { | ||
int *y; | ||
*y = __COUNTER__; // expected-warning{{Dereference of undefined pointer value (loaded from variable 'y')}} | ||
} | ||
|
||
// The checks below confirm that both reports have the same values for __COUNTER__. | ||
// | ||
// FIXME: The correct values are (0, 1, 0, 1). Because we re-lex the file in order | ||
// to detect macro expansions for HTML report purposes, they turn into (2, 3, 2, 3) | ||
// by the time we emit HTML. But at least it's better than (2, 3, 4, 5) | ||
// which would have been the case if we re-lexed the file *each* time we | ||
// emitted an HTML report. | ||
|
||
// CHECK: <span class='macro'>__COUNTER__<span class='macro_popup'>2</span></span> | ||
// CHECK: <span class='macro'>__COUNTER__<span class='macro_popup'>3</span></span> | ||
// CHECK: <span class='macro'>__COUNTER__<span class='macro_popup'>2</span></span> | ||
// CHECK: <span class='macro'>__COUNTER__<span class='macro_popup'>3</span></span> |