Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure Pipeline to Test Recent JDKs #622

Closed
wants to merge 8 commits into from

Conversation

radamson
Copy link

Making updates to the Azure Pipeline so that it tests PRs against multiple JDK Versions. I haven't used Azure Pipelines before, so there might be a better way to do this.

Currently, it doesn't appear that Azure Pipelines support a cross-product matrix strategy like GitHub Actions, but there are some examples of how to replicate the functionality in Azure Pipelines.

fhir-validator-wrapper/41 highlighted a suspected issue that only appeared when using JDK 8 (relevant zulip thread).

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #622 (54c307d) into master (95f7f13) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage    9.56%    9.56%   -0.01%     
==========================================
  Files        1706     1706              
  Lines      534901   534901              
  Branches   159144   159144              
==========================================
- Hits        51150    51148       -2     
  Misses     464179   464179              
- Partials    19572    19574       +2     
Impacted Files Coverage Δ
.../java/org/hl7/fhir/r5/model/ElementDefinition.java 15.64% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca2a67...54c307d. Read the comment docs.

parameters:
imageName: [ 'ubuntu-latest', 'macos-latest', 'windows-2019' ]
jdkVersion: [ '1.8', '1.11']
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add JDK 17 support? It's the most recent LTS version of Java.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add it in, yes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK 17 appears to work with macos and windows, but ubuntu reported Failed to find the specified JDK version.

imageName: "macos-latest"
windows:
imageName: "windows-2019"
maxParallel: 3
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add this back in? If so should it be set to 6?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these appear to be covered in the imageName bracketed arguments above? is that not the case?

Copy link
Author

@radamson radamson Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant maxParallel specifically. The imageNames are covered.

Without maxParallel more than 3 jobs will run simultaneously. As I type 7 of the 9 jobs are running (2 have already failed)

@radamson
Copy link
Author

radamson commented Nov 1, 2021

@markiantorno any other changes you'd like to see in this PR?

@dotasek
Copy link
Collaborator

dotasek commented Nov 16, 2021

@radamson I invested some time in repairing the failing builds in Java 8 and 17 and then used the approach from this PR to create a new one: #653

I will leave this PR open for a response and then close.

@radamson
Copy link
Author

@dotasek thanks for making those fixes/updates? It looks like there isn't a more recent PR where I can see the checks in GitHub, but I can see them happening in Azure Pipelines for your PR. I think the matrix approach I took was overkill now that I see what your config looks like 😅.

Once a new release is out I'll test to see if any of the fixes you implemented address the issue that originally brought this to light. details here and in the zulip thread linked, but TL;DR is that the profiles fetched when loading an IG with the validator varied by JDK version.

@radamson radamson closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants