Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maven config and tests to allow Java 8, 11 and 17 builds #653

Merged
merged 12 commits into from
Nov 16, 2021

Conversation

dotasek
Copy link
Collaborator

@dotasek dotasek commented Nov 10, 2021

  • Updates several dependency versions.
  • Conditionally sets up surefire tests with an optional argument that allows Java 8 surefire tests to run without encountering garbage collection errors.
  • Updates the JAVA_HOME resolution for Mac in UtilityTests to use the resolved path instead of a string, which was failing on different Mac setups due to inconsistencies in using a trailing forward slash for the value.

@dotasek
Copy link
Collaborator Author

dotasek commented Nov 10, 2021

Work in progress; will be adding Azure pipeline targeting this branch to test.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #653 (86cd0a2) into master (f4e9c21) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   10.03%   10.03%           
=======================================
  Files        1728     1728           
  Lines      538009   538009           
  Branches   159335   159340    +5     
=======================================
+ Hits        53966    53968    +2     
  Misses     464364   464364           
+ Partials    19679    19677    -2     
Impacted Files Coverage Δ
...r/utilities/npm/FilesystemPackageCacheManager.java 42.61% <ø> (ø)
.../java/org/hl7/fhir/r5/model/ElementDefinition.java 15.64% <0.00%> (-0.04%) ⬇️
...l7/fhir/validation/instance/InstanceValidator.java 56.57% <0.00%> (+0.08%) ⬆️
...a/org/hl7/fhir/r5/utils/client/network/Client.java 62.16% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232e31d...86cd0a2. Read the comment docs.

@dotasek
Copy link
Collaborator Author

dotasek commented Nov 12, 2021

No longer Work in Progress; ready for review.

Copy link
Collaborator

@markiantorno markiantorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

@markiantorno markiantorno merged commit cccf1ce into master Nov 16, 2021
@markiantorno markiantorno deleted the java-8-11-17-build branch November 16, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants