Timeout for block proposal. #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| leader = consensus.getLeaderPubKey() | ||
| curBlock = bc.CurrentBlock() | ||
| curNumber = curBlock.NumberU64() | ||
| curEpoch = curBlock.Epoch().Uint64() | ||
| ) | ||
| const blocksCountAliveness = 10 | ||
| const blocksCountAliveness = 4 |
There was a problem hiding this comment.
could you please explain this?
There was a problem hiding this comment.
4 is more comfortable for localnet. If no blocks from validator for 4 blocks means validator is inactive, and we can skip him from future rotating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request mainly includes refactoring of the rotateLeader function and additional functions for more detailed logging.