Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip check when the 100% check is achieved. #4625

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Skip check when the 100% check is achieved. #4625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8dff661
fix(consensus): skip is all collected
diego1q2w Feb 1, 2024
a6b7383
fix(consensus): add the IsAllSigsCollected
diego1q2w Feb 1, 2024
d3d9d11
fix(consensus): remove consensus.decider.IsAllSigsCollected()
diego1q2w Feb 1, 2024
ca6c334
fix(consensus): remove code
diego1q2w Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion consensus/consensus_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,10 @@ func (consensus *Consensus) finalCommit() {
return
}
consensus.getLogger().Info().Hex("new", commitSigAndBitmap).Msg("[finalCommit] Overriding commit signatures!!")
consensus.Blockchain().WriteCommitSig(block.NumberU64(), commitSigAndBitmap)

if err := consensus.Blockchain().WriteCommitSig(block.NumberU64(), commitSigAndBitmap); err != nil {
consensus.getLogger().Warn().Err(err).Msg("[finalCommit] failed writting commit sig")
}

// Send committed message before block insertion.
// if leader successfully finalizes the block, send committed message to validators
Expand Down
8 changes: 0 additions & 8 deletions consensus/leader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,6 @@ func (consensus *Consensus) onCommit(recvMsg *FBFTMessage) {
//// Read - Start
viewID := consensus.getCurBlockViewID()

if consensus.decider.IsAllSigsCollected() {
logger.Info().Msg("[OnCommit] 100% Enough commits received")
consensus.finalCommit()

consensus.msgSender.StopRetry(msg_pb.MessageType_PREPARED)
return
}

quorumIsMet := consensus.decider.IsQuorumAchieved(quorum.Commit)
//// Read - End

Expand Down