Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: travis CI changed the way how we install docker - travis updated #4703

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

mur-me
Copy link
Collaborator

@mur-me mur-me commented Jun 26, 2024

Issue

Travis CI changed the way how we install docker - travis updated their basic image and add Docker via docker.list, so I've checked how addon instruction is working under the hood - this is just a tee to sources.list, so I've changed docker.list to have the latest stable Docker.

Details on the failed build:
https://app.travis-ci.com/github/harmony-one/harmony/jobs/623369799
Specifically:

W: Target Packages (stable/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list:51 and /etc/apt/sources.list.d/docker.list:1

Proof from logs that docker is working now:

sudo apt-get -y -o Dpkg::Options::="--force-confnew" install docker-ce
...
The following packages will be upgraded:
  docker-ce
1 upgraded, 0 newly installed, 0 to remove and 41 not upgraded.
Get:1 https://download.docker.com/linux/ubuntu jammy/stable amd64 docker-ce amd64 5:27.0.1-1~ubuntu.22.04~jammy [25.2 MB]
Preparing to unpack .../docker-ce_5%3a27.0.1-1~ubuntu.22.04~jammy_amd64.deb ...
Unpacking docker-ce (5:27.0.1-1~ubuntu.22.04~jammy) over (5:26.1.4-1~ubuntu.22.04~jammy) ...
Setting up docker-ce (5:27.0.1-1~ubuntu.22.04~jammy) ...

Test

Unit Test Coverage

Before:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

After:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

Test/Run Logs

Operational Checklist

  1. Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?. (If no, skip to question 8.)

    YES|NO

  2. Describe the migration plan.. For each flag epoch, describe what changes take place at the flag epoch, the anticipated interactions between upgraded/non-upgraded nodes, and any special operational considerations for the migration.

  3. Describe how the plan was tested.

  4. How much minimum baking period after the last flag epoch should we allow on Pangaea before promotion onto mainnet?

  5. What are the planned flag epoch numbers and their ETAs on Pangaea?

  6. What are the planned flag epoch numbers and their ETAs on mainnet?

    Note that this must be enough to cover baking period on Pangaea.

  7. What should node operators know about this planned change?

  8. Does this PR introduce backward-incompatible changes NOT related to on-disk data structure and/or over-the-wire protocol? (If no, continue to question 11.)

    YES|NO

  9. Does the existing node.sh continue to work with this change?

  10. What should node operators know about this change?

  11. Does this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?

TODO

@mur-me mur-me requested review from Frozen and sophoah June 26, 2024 09:19
their basic image and add Docker via docker.list, so I've checked how
addon instruction is working under the hood - this is just a tee to sources.list, so I've changed docker.list to have the latest stable Docker
@mur-me mur-me force-pushed the feature/fix_for_the_travis_ci_build branch from 6158da0 to ec37bdb Compare June 26, 2024 09:29
@mur-me mur-me requested a review from ONECasey June 26, 2024 12:12
@mur-me
Copy link
Collaborator Author

mur-me commented Jun 26, 2024

Hey @ONECasey, we need this in dev branch to be able to run test 🙏

@Frozen Frozen merged commit 878e75b into dev Jun 27, 2024
4 checks passed
@mur-me mur-me deleted the feature/fix_for_the_travis_ci_build branch June 28, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants