Skip to content

Non-resolvable notes are not shown in winbar #411

@jakubbortlik

Description

@jakubbortlik

Prerequsities

  • I'm on the latest version of the plugin
  • I've installed the required dependencies
  • I've run :h gitlab.nvim.troubleshooting and followed the steps there

Bug Description

The winbar of the discussion tree is useful in showing the number of threads that need to be addressed. Currently, however, it doesn't show the number of non-resolvable notes (i.e., notes that are not a thread with the "Resolve" button). This makes it possible to miss such a note completely in gitlab.nvim

Reproduction Steps

  1. In Gitlab online create a "Comment" (not a Thread!), see screenshot below
  2. Check out the feature branch
  3. Open Neovim
  4. If there are no other notes in the MR and the discussion tree is showing Inline comments, the winbar doesn't give you any hint that there are any Notes at all.

Suggested fix

Add count of non-resolvable notes to the winbar, possibly also replace "resolved" with "threads" and swap the order of resolvable/resolved to resolved/resolvable, as it corresponds better to the way of saying "1 out of 5 are resolved". The final winbar text could look like this: Notes (2 comments; 1/5 threads; 2 drafts).

Screenshots

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions