fix: improve indication of resolved threads and drafts #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "resolved" checkmark is now directly after the number of resolved threads, e.g., "1✓/5". I find this more readily comprehensible than "1/5✓". The drafts are now shown *after* the unlinked comments - this makes the winbar text more stable when adding / removing drafts, as the number of threads is placed always next to unlinked comments.
jakubbortlik
deleted the
fix-improve-indication-of-resolved-threads-and-drafts
branch
harrisoncramer
added a commit
that referenced
this pull request
Dec 11, 2024
* Feat: Enable sorting discussions by original comment (#422) * Feat: Improve popup UX (#426) * Feat: Automatically update MR summary details (#427) * Feat: Show update progress in winbar (#432) * Feat: Abbreviate winbar (#439) * Fix: Note Creation Bug (#441) * Fix: Checking whether comment can be created (#434) * Fix: Syntax in discussion tree (#433) * fix: improve indication of resolved threads and drafts (#442) * Docs: Various minor improvements (#445) --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cosmetic change to the winbar.
The "resolved" checkmark is now directly after the number of resolved threads, e.g., "1✓/5". I find this more readily comprehensible than "1/5✓".
The drafts are now shown after the unlinked comments - this makes the winbar text more stable when adding / removing drafts, as the number of threads is always placed next to unlinked comments.