Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vlan id should be integer type #1099

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Aug 12, 2024

Summary

  • fix vlan id should be integer type
  • allow user to modify vlan Id with empty value
  • ensure input value should between 1 ~ 4094

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #

Occurred changes and/or fixed issues

Technical notes summary

Note. this PR should backport to v1.4 / v1.3 / v1.2

Areas which could experience regressions

Screenshot/Video

fixed.mov

Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 changed the title fix vlan id should be integer type Fix vlan id should be integer type Aug 12, 2024
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix.

@m-ildefons
Copy link

allow user to modify vlan Id with empty value

Why is this necessary? The VLAN ID parameter is mandatory and empty isn't accepted anyways?

@a110605
Copy link
Collaborator Author

a110605 commented Aug 12, 2024

allow user to modify vlan Id with empty value

Why is this necessary? The VLAN ID parameter is mandatory and empty isn't accepted anyways?

It's straighforward to allow user clean up any input in a form.

But original logic keep vlan ID to 1 which is not intuitive.

We have final validation on L116, so I think it's okay to allow clean up the vlan ID input.

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test and work for me, thanks.

@a110605 a110605 merged commit 79bd332 into harvester:master Aug 13, 2024
9 checks passed
@a110605
Copy link
Collaborator Author

a110605 commented Aug 13, 2024

@mergify backport release-harvester-v1.4

Copy link

mergify bot commented Aug 13, 2024

backport release-harvester-v1.4

✅ Backports have been created

@a110605
Copy link
Collaborator Author

a110605 commented Aug 13, 2024

@mergify backport release-harvester-v1.3

@a110605
Copy link
Collaborator Author

a110605 commented Aug 13, 2024

@mergify backport release-harvester-v1.2

Copy link

mergify bot commented Aug 13, 2024

backport release-harvester-v1.3

✅ Backports have been created

Copy link

mergify bot commented Aug 13, 2024

backport release-harvester-v1.2

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants