Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v1.3] [BUG] [UI] Create VM Network VLAN ID input validation buggy #6292

Closed
harvesterhci-io-github-bot opened this issue Aug 7, 2024 · 5 comments
Assignees
Labels
area/ui Harvester standalone UI or Rancher UI extension kind/bug Issues that are defects reported by users or that we know have reached a real release not-require/test-plan Skip to create a e2e automation test issue priority/1 Highly recommended to fix in this release reproduce/always Reproducible 100% of the time reproduce/needed Reminder to add a reproduce label and to remove this one severity/needed Reminder to add a severity label and to remove this one
Milestone

Comments

@harvesterhci-io-github-bot

backport the issue #6290

@harvesterhci-io-github-bot harvesterhci-io-github-bot added area/ui Harvester standalone UI or Rancher UI extension kind/bug Issues that are defects reported by users or that we know have reached a real release not-require/test-plan Skip to create a e2e automation test issue priority/1 Highly recommended to fix in this release reproduce/always Reproducible 100% of the time reproduce/needed Reminder to add a reproduce label and to remove this one severity/needed Reminder to add a severity label and to remove this one labels Aug 7, 2024
@harvesterhci-io-github-bot harvesterhci-io-github-bot added this to the v1.3.2 milestone Aug 7, 2024
@harvesterhci-io-github-bot
Copy link
Author

harvesterhci-io-github-bot commented Aug 9, 2024

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  1. Go to Networks -> VM Networks
  2. Click Create
  3. Vlan ID can input 1 ~ 4094 and should be in integere type in YAML.
  4. Click Create should be successfully.
  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at:

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@a110605
Copy link

a110605 commented Aug 12, 2024

Hi @m-ildefons , since all fixed PR are all merged. Let's move this ticket to ready_for_testing.

@bk201
Copy link
Member

bk201 commented Aug 13, 2024

@m-ildefons the issue is merged we can add some test plan in #6292 (comment) and move it to the ready for testing pipeline.

@m-ildefons
Copy link
Contributor

This fix was superseded by harvester/dashboard#1099
The original issue should remain fixed on v1.3 branch since the above fix was also backported to v1.3 here: harvester/dashboard#1101

@irishgordo irishgordo self-assigned this Aug 27, 2024
@irishgordo
Copy link
Contributor

@m-ildefons thanks for the fix 👍 😄
This looks good on v1.3.2-rc2.
I validated I can have high bound number VLANs and the input be responsive.
Screenshot from 2024-08-27 16-29-29
I'll go ahead and close this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Harvester standalone UI or Rancher UI extension kind/bug Issues that are defects reported by users or that we know have reached a real release not-require/test-plan Skip to create a e2e automation test issue priority/1 Highly recommended to fix in this release reproduce/always Reproducible 100% of the time reproduce/needed Reminder to add a reproduce label and to remove this one severity/needed Reminder to add a severity label and to remove this one
Projects
None yet
Development

No branches or pull requests

5 participants