From dde15c721e7fea4c3eb7e25067ac9beb5229ebce Mon Sep 17 00:00:00 2001
From: Noam Gaash <noam.gaash@gmail.com>
Date: Tue, 16 Jan 2024 11:50:26 +0200
Subject: [PATCH] chore: hide bug report form (#388)

---
 src/routes/index.tsx | 33 ++++++++++++++++++++++++++-------
 tests/menu.spec.ts   |  1 -
 2 files changed, 26 insertions(+), 8 deletions(-)

diff --git a/src/routes/index.tsx b/src/routes/index.tsx
index 500817cb..9c24f8b6 100644
--- a/src/routes/index.tsx
+++ b/src/routes/index.tsx
@@ -26,6 +26,7 @@ import {
 } from '@ant-design/icons'
 import { MainRoute } from './MainRoute'
 import { ErrorPage } from 'src/pages/ErrorPage'
+import { Spin } from 'antd'
 
 export const PAGES = [
   {
@@ -73,6 +74,21 @@ export const PAGES = [
     icon: <InfoCircleOutlined />,
     element: <About />,
   },
+  {
+    label: 'donate_title',
+    path: 'https://www.jgive.com/new/he/ils/donation-targets/3268#donation-modal',
+    icon: <DollarOutlined />,
+    element: null,
+  },
+]
+
+const HIDDEN_PAGES = [
+  {
+    label: 'data-research',
+    path: '/data-research',
+    icon: <InfoCircleOutlined />,
+    element: <DataResearch />,
+  },
   {
     label: 'report_a_bug_title',
     path: 'report-a-bug',
@@ -80,15 +96,20 @@ export const PAGES = [
     element: <BugReportForm />,
   },
   {
-    label: 'donate_title',
-    path: 'https://www.jgive.com/new/he/ils/donation-targets/3268#donation-modal',
-    icon: <DollarOutlined />,
-    element: null,
+    label: 'release',
+    path: '/release',
+    icon: <InfoCircleOutlined />,
+    element: (
+      <>
+        <Spin />
+        <iframe src="https://noam-gaash.co.il/databus/" />
+      </>
+    ),
   },
 ]
 
 const getRoutesList = () => {
-  const pages = PAGES
+  const pages = PAGES.concat(HIDDEN_PAGES)
   const RedirectToDashboard = () => <Navigate to={pages[0].path} replace />
   const routes = pages.filter((r) => r.element)
   return (
@@ -109,8 +130,6 @@ const getRoutesList = () => {
           return gtfs_route
         }}
       />
-      <Route path="data-research" element={<DataResearch />} />
-      <Route path="release" element={<iframe src="https://noam-gaash.co.il/databus/" />} />
       <Route path="*" element={<RedirectToDashboard />} key="back" />
     </Route>
     // </Suspense>
diff --git a/tests/menu.spec.ts b/tests/menu.spec.ts
index 986f30d1..bb89cec7 100644
--- a/tests/menu.spec.ts
+++ b/tests/menu.spec.ts
@@ -11,7 +11,6 @@ test('menu', async ({ page }) => {
     'מפה בזמן אמת',
     'מפה לפי קו',
     'אודות',
-    'דיווח על באג',
     'לתרומות',
   ]
   await expect(page.locator('ul > li a')).toContainText(menuItemsInOrder)