Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project published notification view and template #1792

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

anishTP
Copy link
Contributor

@anishTP anishTP commented Jul 11, 2023

No description provided.

funnel/models/notification_types.py Outdated Show resolved Hide resolved
funnel/models/notification_types.py Outdated Show resolved Hide resolved
funnel/views/project.py Outdated Show resolved Hide resolved
@jace jace mentioned this pull request Jul 12, 2023
)
template = (
"{profile}, whose event you previously registered for, has just announced"
"{project}. Details here: {url}\n\nhttps://bye.li to stop -Hasgeek"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leading space is missing here.

"{profile}, whose event you previously registered for, has just announced"
"{project}. Details here: {url}\n\nhttps://bye.li to stop -Hasgeek"
)
plaintext_template = "{profile} has published a new project: {url}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to have {project} to be sufficiently verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants