Skip to content

Commit

Permalink
updated todo, and added warning if not updating special account keys
Browse files Browse the repository at this point in the history
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
  • Loading branch information
jeromy-cannon committed Feb 12, 2024
1 parent 90307cf commit a2cd8ac
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 3 additions & 1 deletion solo/src/commands/node.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { constants, Templates } from '../core/index.mjs'
import { BaseCommand } from './base.mjs'
import * as flags from './flags.mjs'
import * as prompts from './prompts.mjs'
import { updateAccountKeys } from './flags.mjs'

/**
* Defines the core functionalities of 'node' command
Expand Down Expand Up @@ -489,6 +488,9 @@ export class NodeCommand extends BaseCommand {
task: async (ctx, task) => {
if (ctx.config.updateAccountKeys) {
await self.accountManager.prepareAccounts(ctx.config.namespace)
} else {
this.logger.showUser(chalk.yellowBright('> WARNING:'), chalk.yellow(
'skipping special account keys update, special accounts will retain genesis private keys'))
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions solo/src/core/account_manager.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ export class AccountManager {
* @returns {Promise<void>}
*/
async prepareAccounts (namespace) {
// TODO add disable account key update flag to node start commands or future GH Issue?
const serviceMap = await this.getNodeServiceMap(namespace)

const nodeClient = await this.getNodeClient(
Expand Down Expand Up @@ -137,7 +136,7 @@ export class AccountManager {
`Expected service ${serviceObject.name} to have a loadBalancerIP set for basepath ${this.k8.kubeClient.basePath}`)
}
const host = this.isLocalhost() ? '127.0.0.1' : serviceObject.loadBalancerIp
const port = serviceObject.grpcPort // TODO add grpcs logic
const port = serviceObject.grpcPort // TODO: add grpcs logic in https://github.com/hashgraph/full-stack-testing/issues/752
const targetPort = this.isLocalhost() ? localPort : port

if (this.isLocalhost()) {
Expand Down

0 comments on commit a2cd8ac

Please sign in to comment.