Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct path names for volumes and upgrade minio #762

Merged
merged 8 commits into from
Feb 16, 2024
Merged

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Feb 16, 2024

Description

This pull request changes the following:

  • path name was misspelled for HapiApp2.0
  • path name was incorrect for event streams
  • add _ for bucket path names for consistency
  • enable event streaming
  • update resetHapiDirectories to skip resetting HapiApp2.0/data/saved and HapiApp2.0/data/sats as those are volume mounted for backup-uploader
Screenshot 2024-02-16 at 3 30 26 PM

Related Issues

  • Closes #

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Copy link

github-actions bot commented Feb 16, 2024

Unit Test Results

  26 files  ±0    26 suites  ±0   52s ⏱️ ±0s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ±0 

Results for commit 1a739a1. ± Comparison against base commit e6b5602.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6b5602) 67.51% compared to head (1a739a1) 67.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #762   +/-   ##
=========================================
  Coverage     67.51%   67.51%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1336     1336           
  Branches        157      157           
=========================================
  Hits            902      902           
  Misses          371      371           
  Partials         63       63           

Impacted file tree graph

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy changed the title fix: correct misspelled path name for HapiApp2.0 fix: correct misspelled path names Feb 16, 2024
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy marked this pull request as draft February 16, 2024 03:53
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy changed the title fix: correct misspelled path names fix: correct path names and upgrade minio Feb 16, 2024
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy changed the title fix: correct path names and upgrade minio fix: correct path names for volumes and upgrade minio Feb 16, 2024
@leninmehedy leninmehedy marked this pull request as ready for review February 16, 2024 04:26
@leninmehedy leninmehedy marked this pull request as draft February 16, 2024 07:07
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy marked this pull request as ready for review February 16, 2024 07:15
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jeromy-cannon jeromy-cannon merged commit a8ec593 into main Feb 16, 2024
19 checks passed
@jeromy-cannon jeromy-cannon deleted the fix-path branch February 16, 2024 14:38
swirlds-automation added a commit that referenced this pull request Feb 23, 2024
## [0.22.0](v0.21.0...v0.22.0) (2024-02-23)

### Features

* allow user to create and update accounts with funds from treasury  ([#759](#759)) ([cd2567b](cd2567b))
* rekey special accounts at startup so they are not using genesis keys ([#733](#733)) ([096b5c3](096b5c3))

### Bug Fixes

* **chart:** use selected paths for volumes mount under hgcapp directory ([#751](#751)) ([e1d1c61](e1d1c61))
* **cli:** enhance file copy function of k8 class based on status code ([#758](#758)) ([e6b5602](e6b5602))
* **cli:** refactor config manager with each function having a single responsibility to avoid confusion ([#750](#750)) ([7f45864](7f45864))
* correct path names for volumes and upgrade minio ([#762](#762)) ([a8ec593](a8ec593))
* do version check for dependencies ([#755](#755)) ([520cb47](520cb47))
* **docker:** update location for entrypoint.sh ([#754](#754)) ([7cf02f6](7cf02f6))
* set the mirror node importer addressbook to an invalid value to prevent it from starting ([#777](#777)) ([a12cb1c](a12cb1c))
* use default values for flags during init ([#753](#753)) ([167fb3c](167fb3c))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants