fix: install GatewayClass separately as a shared resource for all namespaces #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… namespaces Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
leninmehedy
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
nathanklick
reviewed
Sep 19, 2023
| @@ -0,0 +1,9 @@ | |||
| apiVersion: gateway.networking.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
We should move this to a separate helm chart and not hide it in the dev tools. This will be necessary for all cluster deployments including automatic cluster setup my the infrastructure library.
There was a problem hiding this comment.
Thanks. I am working on another branch that was created from this branch. I'll convert into a separate chart and update the setup script and values.yaml accordingly as a separate PR to avoid conflicts.
There was a problem hiding this comment.
Created a ticket #361
|
This is superseded by: #363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues