Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): enable --dev flag for dev mode #644

Merged
merged 3 commits into from
Jan 9, 2024
Merged

fix(cli): enable --dev flag for dev mode #644

merged 3 commits into from
Jan 9, 2024

Conversation

leninmehedy
Copy link
Member

Description

This pull request changes the following:

  • enable --dev flag for dev mode
  • removed DEV_MODE env variable settings
  • only show error stacktrace in console if --dev mode is enabled

Related Issues

Copy link

github-actions bot commented Dec 20, 2023

Unit Test Results

  26 files  ±0    26 suites  ±0   54s ⏱️ -5s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ±0 

Results for commit 147fde6. ± Comparison against base commit 8a458d8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@jeromy-cannon jeromy-cannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leninmehedy,

This looks good, my only concern is that we might need to add another issue to track going through the various settings to decide which defaults to enable differently for the charts when in --dev mode versus the default production ready mode.

@leninmehedy
Copy link
Member Author

@leninmehedy,

This looks good, my only concern is that we might need to add another issue to track going through the various settings to decide which defaults to enable differently for the charts when in --dev mode versus the default production ready mode.

Please create an issue with all the defaults required for different settings as you find those.

@jeromy-cannon
Copy link
Contributor

@leninmehedy,
This looks good, my only concern is that we might need to add another issue to track going through the various settings to decide which defaults to enable differently for the charts when in --dev mode versus the default production ready mode.

Please create an issue with all the defaults required for different settings as you find those.

done: hashgraph/solo#41

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a458d8) 67.51% compared to head (147fde6) 67.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     hashgraph/full-stack-testing#644   +/-   ##
=========================================
  Coverage     67.51%   67.51%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1336     1336           
  Branches        157      157           
=========================================
  Hits            902      902           
  Misses          371      371           
  Partials         63       63           

Impacted file tree graph

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leninmehedy leninmehedy merged commit 617b948 into main Jan 9, 2024
19 checks passed
@leninmehedy leninmehedy deleted the 622-dev-mode branch January 9, 2024 23:02
swirlds-automation added a commit that referenced this pull request Jan 10, 2024
## [0.16.0](v0.15.0...v0.16.0) (2024-01-10)

### Features

* update charts to be able to leverage external static IP addresses ([#650](#650)) ([8a458d8](8a458d8))

### Bug Fixes

* **cli:** enable --dev flag for dev mode ([#644](#644)) ([617b948](617b948))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

JeffreyDallas pushed a commit that referenced this pull request Jan 10, 2024
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirlds.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: fsnetman default to production ready with a --dev switch for local development
3 participants