-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): enable --dev flag for dev mode #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, my only concern is that we might need to add another issue to track going through the various settings to decide which defaults to enable differently for the charts when in --dev
mode versus the default production ready mode.
Please create an issue with all the defaults required for different settings as you find those. |
done: hashgraph/solo#41 |
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
883b559
to
645418b
Compare
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main hashgraph/full-stack-testing#644 +/- ##
=========================================
Coverage 67.51% 67.51%
Complexity 339 339
=========================================
Files 64 64
Lines 1336 1336
Branches 157 157
=========================================
Hits 902 902
Misses 371 371
Partials 63 63 |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
🎉 This PR is included in version 0.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Signed-off-by: Jeffrey Tang <jeffrey@swirlds.com>
Description
This pull request changes the following:
--dev
mode is enabledRelated Issues
--dev
switch for local development #622