fix: use default values for all flags during init #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
leninmehedy
commented
Feb 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
=========================================
Coverage 67.51% 67.51%
Complexity 339 339
=========================================
Files 64 64
Lines 1336 1336
Branches 157 157
=========================================
Hits 902 902
Misses 371 371
Partials 63 63 |
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
This was referenced Feb 13, 2024
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> # Conflicts: # solo/test/e2e/commands/node.test.mjs
jeromy-cannon
approved these changes
Feb 13, 2024
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
|
swirlds-automation
added a commit
that referenced
this pull request
Feb 23, 2024
## [0.22.0](v0.21.0...v0.22.0) (2024-02-23) ### Features * allow user to create and update accounts with funds from treasury ([#759](#759)) ([cd2567b](cd2567b)) * rekey special accounts at startup so they are not using genesis keys ([#733](#733)) ([096b5c3](096b5c3)) ### Bug Fixes * **chart:** use selected paths for volumes mount under hgcapp directory ([#751](#751)) ([e1d1c61](e1d1c61)) * **cli:** enhance file copy function of k8 class based on status code ([#758](#758)) ([e6b5602](e6b5602)) * **cli:** refactor config manager with each function having a single responsibility to avoid confusion ([#750](#750)) ([7f45864](7f45864)) * correct path names for volumes and upgrade minio ([#762](#762)) ([a8ec593](a8ec593)) * do version check for dependencies ([#755](#755)) ([520cb47](520cb47)) * **docker:** update location for entrypoint.sh ([#754](#754)) ([7cf02f6](7cf02f6)) * set the mirror node importer addressbook to an invalid value to prevent it from starting ([#777](#777)) ([a12cb1c](a12cb1c)) * use default values for flags during init ([#753](#753)) ([167fb3c](167fb3c))
|
🎉 This PR is included in version 0.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues