From d447f17b184e955da21840f53ee4d6de7dc64d8c Mon Sep 17 00:00:00 2001 From: Mugdha Goel Date: Thu, 15 Aug 2024 14:47:30 -0400 Subject: [PATCH 1/6] Adding mirror node update section to HIP-869 --- HIP/hip-869.md | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/HIP/hip-869.md b/HIP/hip-869.md index be0f3956d..602925db4 100644 --- a/HIP/hip-869.md +++ b/HIP/hip-869.md @@ -563,6 +563,60 @@ When executing the next `freeze` transaction with `freeze_type` set to `PREPARE_ All HIPs that introduce backward incompatibilities must include a section describing these incompatibilities and their severity. The HIP must explain how the author proposes to deal with these incompatibilities. HIP submissions without a sufficient backward compatibility treatise may be rejected outright. +### Mirror node update +The mirror node will process the new Node transactions and service_endpoint information, +then returns that information through its existing APIs. + +The following changes will be made to the GRPC API: +- Update the network service to add `domain_name` and `admin_key`. + +The following changes will be made to the REST API: + +- Update the `/api/v1/network/nodes` endpoint to return `domain_name` and `admin_key` + +Example response: + +```json +{ + "nodes": [ + { + "admin_key": "0x565fd764f0957fa170a676210c9bdbddf3bc9519702cf927fa6767a40463b96f", + "description": "address book 1", + "file_id": "0.0.102", + "max_stake": 50000, + "memo": "0.0.4", + "min_stake": 1000, + "node_account_id": "0.0.4", + "node_cert_hash": "0x01d173753810c0aae794ba72d5443c292e9ff962b01046220dd99f5816422696e0569c977e2f169e1e5688afc8f4aa16", + "node_id": 1, + "public_key": "0x4a5ad514f0957fa170a676210c9bdbddf3bc9519702cf915fa6767a40463b96f", + "reward_rate_start": 1000000, + "service_endpoints": [ + { + "domain_name": "examplenode.com", + "ip_address_v4": "128.0.0.6", + "port": 50216 + } + ], + "stake": 20000, + "stake_not_rewarded": 19900, + "stake_rewarded": 100, + "staking_period": { + "from": "1655164800.000000000", + "to": "1655251200.000000000" + }, + "timestamp": { + "from": "187654.000123457", + "to": null + } + } + ], + "links": { + "next": null + } +} +``` + ## Security Implications No security issues identified as of yet From ada482a64808bcfadd7bca1936d3205a08c958d3 Mon Sep 17 00:00:00 2001 From: Mugdha Goel Date: Thu, 15 Aug 2024 14:52:02 -0400 Subject: [PATCH 2/6] Editing text. --- HIP/hip-869.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/HIP/hip-869.md b/HIP/hip-869.md index 602925db4..fafece6b1 100644 --- a/HIP/hip-869.md +++ b/HIP/hip-869.md @@ -564,14 +564,12 @@ When executing the next `freeze` transaction with `freeze_type` set to `PREPARE_ All HIPs that introduce backward incompatibilities must include a section describing these incompatibilities and their severity. The HIP must explain how the author proposes to deal with these incompatibilities. HIP submissions without a sufficient backward compatibility treatise may be rejected outright. ### Mirror node update -The mirror node will process the new Node transactions and service_endpoint information, -then returns that information through its existing APIs. +The mirror node will process the new Node transactions and service_endpoint information, then return that information through its existing APIs. The following changes will be made to the GRPC API: - Update the network service to add `domain_name` and `admin_key`. The following changes will be made to the REST API: - - Update the `/api/v1/network/nodes` endpoint to return `domain_name` and `admin_key` Example response: From dcf5d2a130de44ed9a75625e7ecbd10fe04c0c96 Mon Sep 17 00:00:00 2001 From: Mugdha Goel Date: Thu, 15 Aug 2024 14:54:47 -0400 Subject: [PATCH 3/6] Update date. --- HIP/hip-869.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HIP/hip-869.md b/HIP/hip-869.md index fafece6b1..f5845159b 100644 --- a/HIP/hip-869.md +++ b/HIP/hip-869.md @@ -11,7 +11,7 @@ status: Accepted last-call-date-time: 2023-02-14T07:00:00Z created: 2024-01-22 discussions-to: https://github.com/hashgraph/hedera-improvement-proposal/pull/869 -updated: 2024-07-31 +updated: 2024-08-15 --- ## Abstract From 45c3bd74f2ce9a78503134b9e76be65ffaa9939b Mon Sep 17 00:00:00 2001 From: Mugdha Goel Date: Mon, 19 Aug 2024 15:53:55 -0400 Subject: [PATCH 4/6] Fixing admin_key type. --- HIP/hip-869.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/HIP/hip-869.md b/HIP/hip-869.md index f5845159b..b6c9625c0 100644 --- a/HIP/hip-869.md +++ b/HIP/hip-869.md @@ -578,7 +578,10 @@ Example response: { "nodes": [ { - "admin_key": "0x565fd764f0957fa170a676210c9bdbddf3bc9519702cf927fa6767a40463b96f", + "admin_key": { + "_type": "ProtobufEncoded", + "key": 10101 + }, "description": "address book 1", "file_id": "0.0.102", "max_stake": 50000, From 5d9eaac684b4c0c30b23507cbe496e2dda86da04 Mon Sep 17 00:00:00 2001 From: Mugdha Goel Date: Mon, 19 Aug 2024 15:55:02 -0400 Subject: [PATCH 5/6] Change update date. --- HIP/hip-869.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HIP/hip-869.md b/HIP/hip-869.md index b6c9625c0..06f11d1b1 100644 --- a/HIP/hip-869.md +++ b/HIP/hip-869.md @@ -11,7 +11,7 @@ status: Accepted last-call-date-time: 2023-02-14T07:00:00Z created: 2024-01-22 discussions-to: https://github.com/hashgraph/hedera-improvement-proposal/pull/869 -updated: 2024-08-15 +updated: 2024-08-19 --- ## Abstract From a5d12060505785caaf08bb2ef4c10f2933ea9c9e Mon Sep 17 00:00:00 2001 From: Mugdha Goel Date: Mon, 19 Aug 2024 17:51:18 -0400 Subject: [PATCH 6/6] Updating the admin_key type. --- HIP/hip-869.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/HIP/hip-869.md b/HIP/hip-869.md index 06f11d1b1..9a1901202 100644 --- a/HIP/hip-869.md +++ b/HIP/hip-869.md @@ -579,8 +579,8 @@ Example response: "nodes": [ { "admin_key": { - "_type": "ProtobufEncoded", - "key": 10101 + "_type": "ED25519", + "key": "308201a2300d06092a864886f70d01010105000382018f003082018a028100e0" }, "description": "address book 1", "file_id": "0.0.102",