-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conforming Guardian’s Sustainability Assets to an Enhanced HIP412 Standard #929
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for hedera-hips failed.
|
0bd8fdf
to
e4fbd26
Compare
you should not edit the template instead create a new file |
hip-0000-template.md
Outdated
"attributes": [ | ||
{ | ||
"trait_type": "timestamp", | ||
"value": 1710271999.591571 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HIP412 specifies a unix timestamp in seconds. We might need to specify that validators should consider nano seconds too for timestamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should switch to string in this case.
hip-0000-template.md
Outdated
"trait_type": "timestamp", | ||
"value": "1710271999.591571003" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default display type in HIP412 is text
. We can help explorers by adding the way we would like this represented.
"trait_type": "timestamp", | |
"value": "1710271999.591571003" | |
"trait_type": "timestamp", | |
"display_type": "datetime", | |
"value": "1710271999.591571003" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, is there a way for a attribute to be non-indexable as filtering on timestamps is nonsense
hip-0000-template.md
Outdated
"value": [ | ||
"air", | ||
"water", | ||
"soil", | ||
"biodiversity", | ||
"equity", | ||
"carbon" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HIP 412 doesn't support arrays so we'll need to raise this as a new value type that can be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing explorers would need to make changes to their filtering features to support arrays here.
The alternative is to list them all at the root level which would allow them to act as filters without any change to existing NFT markets.
{
"trait_type": "co-benefits-air",
"display_type": "boolean",
"value": true
},
{
"trait_type": "co-benefits-water",
"display_type": "boolean",
"value": true
},
I do prefer the array solution originally proposed, just be aware that it can't be used as a filter out of the gate until markets update to support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this.
Sorry sir, will resolve. |
Signed-off-by: Matt Smithies <flyinggazelle@hotmail.co.uk>
Signed-off-by: Matt Smithies <flyinggazelle@hotmail.co.uk>
Signed-off-by: Matt Smithies <flyinggazelle@hotmail.co.uk>
3814938
to
4d0eaaf
Compare
Updated the current HIP with changes from @justynspooner, @fessmm, and @Neurone there will likely be more changes moving forward, but if anyone wants to add any additional thoughts around this, that would be great! |
Description:
This PR adds a new draft HIP titled "Conforming Guardian’s Sustainability Assets to an Enhanced HIP412 Standard". This new HIP was created by Sustainability/Guardian Working Group in collaboration with the community over a period of 6 months. It enables guardian standard compliant systems a method to map verified sustainability data from trustchains into a NFT (HIP412) form suitable to be consumed from any external service, such as marketplaces and wallets.
Checklist